From f60ce8a48b97eb970bfbec1f26c914b9017c4a46 Mon Sep 17 00:00:00 2001 From: Lin Ma Date: Thu, 15 Jun 2023 23:22:40 +0800 Subject: [PATCH] net: mctp: remove redundant RTN_UNICAST check Current mctp_newroute() contains two exactly same check against rtm->rtm_type static int mctp_newroute(...) { ... if (rtm->rtm_type != RTN_UNICAST) { // (1) NL_SET_ERR_MSG(extack, "rtm_type must be RTN_UNICAST"); return -EINVAL; } ... if (rtm->rtm_type != RTN_UNICAST) // (2) return -EINVAL; ... } This commits removes the (2) check as it is redundant. Signed-off-by: Lin Ma Reviewed-by: Pavan Chebbi Acked-by: Jeremy Kerr Link: https://lore.kernel.org/r/20230615152240.1749428-1-linma@zju.edu.cn Signed-off-by: Jakub Kicinski --- net/mctp/route.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/mctp/route.c b/net/mctp/route.c index f51a05e..ab62fe4 100644 --- a/net/mctp/route.c +++ b/net/mctp/route.c @@ -1249,9 +1249,6 @@ static int mctp_newroute(struct sk_buff *skb, struct nlmsghdr *nlh, mtu = nla_get_u32(tbx[RTAX_MTU]); } - if (rtm->rtm_type != RTN_UNICAST) - return -EINVAL; - rc = mctp_route_add(mdev, daddr_start, rtm->rtm_dst_len, mtu, rtm->rtm_type); return rc; -- 2.7.4