From f5f4ca7871ec2be2b5666a7b9e6e5e28133b8393 Mon Sep 17 00:00:00 2001 From: Behdad Esfahbod Date: Wed, 7 Nov 2018 11:21:09 -0500 Subject: [PATCH] [kern/kerx] Enable crossStream kerning in vertical CoreText doesn't, but no reason we shouldn't do. --- src/hb-aat-layout-kerx-table.hh | 8 ++++---- src/hb-ot-kern-table.hh | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/hb-aat-layout-kerx-table.hh b/src/hb-aat-layout-kerx-table.hh index 2a12a0b..3418327 100644 --- a/src/hb-aat-layout-kerx-table.hh +++ b/src/hb-aat-layout-kerx-table.hh @@ -334,10 +334,10 @@ struct KerxSubTableFormat1 { if (crossStream) { - /* CoreText doesn't do crossStream kerning in vertical. */ - //crossOffset += v; - //if (!buffer->pos[idx].x_offset) - // buffer->pos[idx].x_offset = c->font->em_scale_x (crossOffset); + /* CoreText doesn't do crossStream kerning in vertical. We do. */ + crossOffset += v; + if (!buffer->pos[idx].x_offset) + buffer->pos[idx].x_offset = c->font->em_scale_x (crossOffset); } else { diff --git a/src/hb-ot-kern-table.hh b/src/hb-ot-kern-table.hh index e065b6f..e205b4b 100644 --- a/src/hb-ot-kern-table.hh +++ b/src/hb-ot-kern-table.hh @@ -161,10 +161,10 @@ struct KernSubTableFormat1 { if (crossStream) { - /* CoreText doesn't do crossStream kerning in vertical. */ - //crossOffset += v; - //if (!buffer->pos[idx].x_offset) - // buffer->pos[idx].x_offset = c->font->em_scale_x (crossOffset); + /* CoreText doesn't do crossStream kerning in vertical. We do. */ + crossOffset += v; + if (!buffer->pos[idx].x_offset) + buffer->pos[idx].x_offset = c->font->em_scale_x (crossOffset); } else { -- 2.7.4