From f5e854f71c3afd7b3c70f418cca7801a48b6a928 Mon Sep 17 00:00:00 2001 From: "kj7.sung" Date: Wed, 19 Apr 2017 18:06:02 +0900 Subject: [PATCH] Fix svace issue Change-Id: I918a1b8878b4391b6f8a79bed2cd32127ca77449 Signed-off-by: kj7.sung --- gps-plugin/src/gps_plugin_replay.c | 2 +- gps-plugin/src/nmea_parser.c | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gps-plugin/src/gps_plugin_replay.c b/gps-plugin/src/gps_plugin_replay.c index 851f00a..61eaa5a 100644 --- a/gps-plugin/src/gps_plugin_replay.c +++ b/gps-plugin/src/gps_plugin_replay.c @@ -308,7 +308,7 @@ gboolean gps_plugin_replay_read_nmea(replay_timeout *timer, char *nmea_data) break; } else if (ref == 1) { /* LOG_PLUGIN(DBG_LOW, "1st GPGGA : start to read nmea data"); */ - strncpy(nmea_data, buf, strlen(buf)); + strncpy(nmea_data, buf, strlen(buf) - 1); } } else { if (strlen(nmea_data) + strlen(buf) > REPLAY_NMEA_SET_SIZE) { diff --git a/gps-plugin/src/nmea_parser.c b/gps-plugin/src/nmea_parser.c index 945bd17..6beafc5 100644 --- a/gps-plugin/src/nmea_parser.c +++ b/gps-plugin/src/nmea_parser.c @@ -290,6 +290,11 @@ static int nmea_parser_gpgsv(char *token[], sv_data_t *sv) } num_sv = atoi(token[3]); + if (num_sv > MAX_GPS_NUM_SAT_IN_VIEW) { + LOG_PLUGIN(DBG_LOW, "num_of_sat(num_sv) size error"); + return READ_ERROR; + } + sv->num_of_sat = num_sv; iter = ((num_sv < (msg_num * 4)) ? (num_sv - ((msg_num - 1) * 4)) : 4); for (i = 0; i < iter; i++) { -- 2.34.1