From f53ed631b325c82097d3511c44671348d178882f Mon Sep 17 00:00:00 2001 From: Steve Holme Date: Wed, 27 Feb 2013 20:53:34 +0000 Subject: [PATCH] imap: Reversed the logic of the (un)successful tagged SELECT response Reversed the logic of the unsuccessful vs successful tagged SELECT response in imap_state_select_resp() to be more logical to read. --- lib/imap.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/imap.c b/lib/imap.c index cfde001..ae2fd41 100644 --- a/lib/imap.c +++ b/lib/imap.c @@ -1233,11 +1233,7 @@ static CURLcode imap_state_select_resp(struct connectdata *conn, imapc->mailbox_uidvalidity = strdup(tmp); } } - else if(imapcode != 'O') { - failf(data, "Select failed"); - result = CURLE_LOGIN_DENIED; - } - else { + else if(imapcode == 'O') { /* Check if the UIDVALIDITY has been specified and matches */ if(imap->uidvalidity && imapc->mailbox_uidvalidity && strcmp(imap->uidvalidity, imapc->mailbox_uidvalidity)) { @@ -1251,6 +1247,10 @@ static CURLcode imap_state_select_resp(struct connectdata *conn, result = imap_fetch(conn); } } + else { + failf(data, "Select failed"); + result = CURLE_LOGIN_DENIED; + } return result; } -- 2.7.4