From f5381ba9f5c20b62ad2d791404f4ccb47383b704 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Sebastian=20Dr=C3=B6ge?= Date: Wed, 24 Feb 2021 19:51:40 +0200 Subject: [PATCH] audioaggregator: Log if the sample rate of one sinkpad is not accepted Otherwise this can silently cause not-negotiated errors without any direct hint about what went wrong. Part-of: --- gst-libs/gst/audio/gstaudioaggregator.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/gst-libs/gst/audio/gstaudioaggregator.c b/gst-libs/gst/audio/gstaudioaggregator.c index dd6e7dd..85dbd2a 100644 --- a/gst-libs/gst/audio/gstaudioaggregator.c +++ b/gst-libs/gst/audio/gstaudioaggregator.c @@ -900,7 +900,8 @@ gst_audio_aggregator_sink_setcaps (GstAudioAggregatorPad * aaggpad, gboolean downstream_supports_rate = TRUE; if (!gst_audio_info_from_caps (&info, caps)) { - GST_WARNING_OBJECT (agg, "Rejecting invalid caps: %" GST_PTR_FORMAT, caps); + GST_WARNING_OBJECT (aaggpad, "Rejecting invalid caps: %" GST_PTR_FORMAT, + caps); return FALSE; } @@ -933,6 +934,10 @@ gst_audio_aggregator_sink_setcaps (GstAudioAggregatorPad * aaggpad, if (!downstream_supports_rate || (first_configured_pad && info.rate != first_configured_pad->info.rate)) { + GST_WARNING_OBJECT (aaggpad, + "Sample rate %d can't be configured (downstream supported: %d, configured rate: %d)", + info.rate, downstream_supports_rate, + first_configured_pad ? first_configured_pad->info.rate : 0); gst_pad_push_event (GST_PAD (aaggpad), gst_event_new_reconfigure ()); ret = FALSE; } else { -- 2.7.4