From f53347631eb4a5a075589e6fece43aced010a5bb Mon Sep 17 00:00:00 2001 From: Daniel Stenberg Date: Fri, 13 Oct 2006 14:01:19 +0000 Subject: [PATCH] Added comments about checking return code and the maxfd counter --- docs/examples/10-at-a-time.c | 3 +++ docs/examples/fopen.c | 4 ++++ docs/examples/multi-app.c | 4 ++++ docs/examples/multi-debugcallback.c | 4 ++++ docs/examples/multi-double.c | 4 ++++ docs/examples/multi-post.c | 4 ++++ docs/examples/multi-single.c | 4 ++++ 7 files changed, 27 insertions(+) diff --git a/docs/examples/10-at-a-time.c b/docs/examples/10-at-a-time.c index be3b6fa..5039225 100644 --- a/docs/examples/10-at-a-time.c +++ b/docs/examples/10-at-a-time.c @@ -123,6 +123,9 @@ int main(void) return EXIT_FAILURE; } + /* In a real-world program you OF COURSE check the return that maxfd is + bigger than -1 so that the call to select() below makes sense! */ + if (curl_multi_timeout(cm, &L)) { fprintf(stderr, "E: curl_multi_timeout\n"); return EXIT_FAILURE; diff --git a/docs/examples/fopen.c b/docs/examples/fopen.c index a2e6fc9..de235bb 100644 --- a/docs/examples/fopen.c +++ b/docs/examples/fopen.c @@ -153,6 +153,10 @@ fill_buffer(URL_FILE *file,int want,int waittime) /* get file descriptors from the transfers */ curl_multi_fdset(multi_handle, &fdread, &fdwrite, &fdexcep, &maxfd); + /* In a real-world program you OF COURSE check the return code of the + function calls, *and* you make sure that maxfd is bigger than -1 + so that the call to select() below makes sense! */ + rc = select(maxfd+1, &fdread, &fdwrite, &fdexcep, &timeout); switch(rc) { diff --git a/docs/examples/multi-app.c b/docs/examples/multi-app.c index 5383a40..6c0ef7e 100644 --- a/docs/examples/multi-app.c +++ b/docs/examples/multi-app.c @@ -80,6 +80,10 @@ int main(int argc, char **argv) /* get file descriptors from the transfers */ curl_multi_fdset(multi_handle, &fdread, &fdwrite, &fdexcep, &maxfd); + /* In a real-world program you OF COURSE check the return code of the + function calls, *and* you make sure that maxfd is bigger than -1 so + that the call to select() below makes sense! */ + rc = select(maxfd+1, &fdread, &fdwrite, &fdexcep, &timeout); switch(rc) { diff --git a/docs/examples/multi-debugcallback.c b/docs/examples/multi-debugcallback.c index 2862672..4c93df4 100644 --- a/docs/examples/multi-debugcallback.c +++ b/docs/examples/multi-debugcallback.c @@ -153,6 +153,10 @@ int main(int argc, char **argv) /* get file descriptors from the transfers */ curl_multi_fdset(multi_handle, &fdread, &fdwrite, &fdexcep, &maxfd); + /* In a real-world program you OF COURSE check the return code of the + function calls, *and* you make sure that maxfd is bigger than -1 + so that the call to select() below makes sense! */ + rc = select(maxfd+1, &fdread, &fdwrite, &fdexcep, &timeout); switch(rc) { diff --git a/docs/examples/multi-double.c b/docs/examples/multi-double.c index 51b4ed3..0a4cde8 100644 --- a/docs/examples/multi-double.c +++ b/docs/examples/multi-double.c @@ -71,6 +71,10 @@ int main(int argc, char **argv) /* get file descriptors from the transfers */ curl_multi_fdset(multi_handle, &fdread, &fdwrite, &fdexcep, &maxfd); + /* In a real-world program you OF COURSE check the return code of the + function calls, *and* you make sure that maxfd is bigger than -1 so + that the call to select() below makes sense! */ + rc = select(maxfd+1, &fdread, &fdwrite, &fdexcep, &timeout); switch(rc) { diff --git a/docs/examples/multi-post.c b/docs/examples/multi-post.c index b89e2d6..894ace0 100644 --- a/docs/examples/multi-post.c +++ b/docs/examples/multi-post.c @@ -93,6 +93,10 @@ int main(int argc, char *argv[]) /* get file descriptors from the transfers */ curl_multi_fdset(multi_handle, &fdread, &fdwrite, &fdexcep, &maxfd); + /* In a real-world program you OF COURSE check the return code of the + function calls, *and* you make sure that maxfd is bigger than -1 + so that the call to select() below makes sense! */ + rc = select(maxfd+1, &fdread, &fdwrite, &fdexcep, &timeout); switch(rc) { diff --git a/docs/examples/multi-single.c b/docs/examples/multi-single.c index 0ba932f..b23f3c9 100644 --- a/docs/examples/multi-single.c +++ b/docs/examples/multi-single.c @@ -65,6 +65,10 @@ int main(int argc, char **argv) /* get file descriptors from the transfers */ curl_multi_fdset(multi_handle, &fdread, &fdwrite, &fdexcep, &maxfd); + /* In a real-world program you OF COURSE check the return code of the + function calls, *and* you make sure that maxfd is bigger than -1 so + that the call to select() below makes sense! */ + rc = select(maxfd+1, &fdread, &fdwrite, &fdexcep, &timeout); switch(rc) { -- 2.7.4