From f51557dbc5a46d25e37cbb0870d02778e9a0f074 Mon Sep 17 00:00:00 2001 From: Stefan Sauer Date: Wed, 1 Nov 2017 15:18:08 +0100 Subject: [PATCH] aggregator: add more comments --- libs/gst/base/gstaggregator.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/libs/gst/base/gstaggregator.c b/libs/gst/base/gstaggregator.c index fdffa37..b757cff 100644 --- a/libs/gst/base/gstaggregator.c +++ b/libs/gst/base/gstaggregator.c @@ -286,6 +286,8 @@ struct _GstAggregatorPrivate /* Our state is >= PAUSED */ gboolean running; /* protected by src_lock */ + /* seqnum from seek or segment, + * to be applied to synthetic segment/eos events */ gint seqnum; gboolean send_stream_start; /* protected by srcpad stream lock */ gboolean send_segment; @@ -561,6 +563,8 @@ gst_aggregator_push_mandatory_events (GstAggregator * self) segment = gst_event_new_segment (&self->segment); if (!self->priv->seqnum) + /* This code-path is in preparation to be able to run without a source + * connected. Then we won't have a seq-num from a segment event. */ self->priv->seqnum = gst_event_get_seqnum (segment); else gst_event_set_seqnum (segment, self->priv->seqnum); @@ -1103,6 +1107,8 @@ gst_aggregator_aggregate_func (GstAggregator * self) gst_aggregator_iterate_sinkpads (self, gst_aggregator_do_events_and_queries, NULL); + /* Ensure we have buffers ready (either in clipped_buffer or at the head of + * the queue */ if (!gst_aggregator_wait_and_check (self, &timeout)) continue; -- 2.7.4