From f4d6fcda3ad78053d0b778a6a269b0b041b5441d Mon Sep 17 00:00:00 2001 From: "yangguo@chromium.org" Date: Mon, 11 Aug 2014 19:38:01 +0000 Subject: [PATCH] Allow externalizing cons and sliced string. Fulfill overdue TODO. R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/460643002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23058 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/api.cc | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/api.cc b/src/api.cc index abe50f6..538071a 100644 --- a/src/api.cc +++ b/src/api.cc @@ -5545,11 +5545,6 @@ bool v8::String::CanMakeExternal() { i::Handle obj = Utils::OpenHandle(this); i::Isolate* isolate = obj->GetIsolate(); - // TODO(yangguo): Externalizing sliced/cons strings allocates. - // This rule can be removed when all code that can - // trigger an access check is handlified and therefore GC safe. - if (isolate->heap()->old_pointer_space()->Contains(*obj)) return false; - if (isolate->string_tracker()->IsFreshUnusedString(obj)) return false; int size = obj->Size(); // Byte size of the original string. if (size < i::ExternalString::kShortSize) return false; -- 2.7.4