From f4a4f50abe5755711174a40216d3ae40c80e51d3 Mon Sep 17 00:00:00 2001 From: Naushir Patuck Date: Thu, 5 Jan 2023 11:04:48 +0000 Subject: [PATCH] imx708: Do not reset vblank to a default value imx708_set_framing_limits resets the vblank control to the mode default value unconditionally. This causes it to overwrite the user specified vblank and exposure control values when starting the sensor, since it is called when handling V4L2_CID_WIDE_DYNAMIC_RANGE. Remove this call to s_ctrl as it is unnecessary. Signed-off-by: Naushir Patuck [sw0312.kim: cherry-pick raspberry pi kernel upstream to support rpi camera module v3] Signed-off-by: Seung-Woo Kim Change-Id: I60555efb022b889febd1720a6e15bb3e009bb55c --- drivers/media/i2c/imx708.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/media/i2c/imx708.c b/drivers/media/i2c/imx708.c index ad4eeb9..8961ea1 100644 --- a/drivers/media/i2c/imx708.c +++ b/drivers/media/i2c/imx708.c @@ -1041,9 +1041,6 @@ static void imx708_set_framing_limits(struct imx708 *imx708) IMX708_FRAME_LENGTH_MAX - mode->height, 1, mode->vblank_default); - /* Setting this will adjust the exposure limits as well. */ - __v4l2_ctrl_s_ctrl(imx708->vblank, mode->vblank_default); - /* * Currently PPL is fixed to the mode specified value, so hblank * depends on mode->width only, and is not changeable in any -- 2.7.4