From f497c16c2698e5f2ecd6a33f174982b2f826d48e Mon Sep 17 00:00:00 2001 From: Jakub Jelinek Date: Wed, 20 Jun 2007 08:37:17 +0200 Subject: [PATCH] re PR inline-asm/32109 (ICE with inline-asm and class with destructor) PR inline-asm/32109 * gimplify.c (gimplify_asm_expr): Issue error if type is addressable and !allows_mem. * g++.dg/ext/asm10.C: New test. From-SVN: r125874 --- gcc/ChangeLog | 4 ++++ gcc/gimplify.c | 13 +++++++++++++ gcc/testsuite/ChangeLog | 3 +++ gcc/testsuite/g++.dg/ext/asm10.C | 14 ++++++++++++++ 4 files changed, 34 insertions(+) create mode 100644 gcc/testsuite/g++.dg/ext/asm10.C diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 7b3e68d..b73ef81 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,5 +1,9 @@ 2007-06-20 Jakub Jelinek + PR inline-asm/32109 + * gimplify.c (gimplify_asm_expr): Issue error if type is addressable + and !allows_mem. + PR middle-end/32285 * calls.c (precompute_arguments): Also precompute CALL_EXPR arguments if ACCUMULATE_OUTGOING_ARGS. diff --git a/gcc/gimplify.c b/gcc/gimplify.c index 774af9a..01ccaf0 100644 --- a/gcc/gimplify.c +++ b/gcc/gimplify.c @@ -4122,6 +4122,19 @@ gimplify_asm_expr (tree *expr_p, tree *pre_p, tree *post_p) parse_input_constraint (&constraint, 0, 0, noutputs, 0, oconstraints, &allows_mem, &allows_reg); + /* If we can't make copies, we can only accept memory. */ + if (TREE_ADDRESSABLE (TREE_TYPE (TREE_VALUE (link)))) + { + if (allows_mem) + allows_reg = 0; + else + { + error ("impossible constraint in %"); + error ("non-memory input %d must stay in memory", i); + return GS_ERROR; + } + } + /* If the operand is a memory input, it should be an lvalue. */ if (!allows_reg && allows_mem) { diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 20b44c8..0cefc19 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,5 +1,8 @@ 2007-06-20 Jakub Jelinek + PR inline-asm/32109 + * g++.dg/ext/asm10.C: New test. + PR middle-end/32285 * gcc.c-torture/execute/20070614-1.c: New test. diff --git a/gcc/testsuite/g++.dg/ext/asm10.C b/gcc/testsuite/g++.dg/ext/asm10.C new file mode 100644 index 0000000..b95027c --- /dev/null +++ b/gcc/testsuite/g++.dg/ext/asm10.C @@ -0,0 +1,14 @@ +// PR inline-asm/32109 +// { dg-do compile } +// { dg-options "-O2" } + +struct A { int i[3]; ~A (); }; +struct A a; +struct B { struct A c; int i; B (); } b; + +B::B () +{ + __asm ("" : : "r" (a)); // { dg-error "impossible constraint|non-memory input" } + __asm ("" : : "r" (b.c)); // { dg-error "impossible constraint|non-memory input" } + __asm ("" : : "r" (c)); // { dg-error "impossible constraint|non-memory input" } +} -- 2.7.4