From f407231c855bc0349d0f8543a9dfe9dff4b2508b Mon Sep 17 00:00:00 2001 From: Alan Coopersmith Date: Mon, 21 Jan 2013 23:03:48 -0800 Subject: [PATCH] Declare 'len' as size_t to avoid unneccessary back-and-forth conversions Fixes clang warnings: xdpyinfo.c:1463:12: warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int' [-Wshorten-64-to-32] int len = strlen(arg); ~~~ ^~~~~~~~~~~ xdpyinfo.c:1465:32: warning: implicit conversion changes signedness: 'int' to 'size_t' (aka 'unsigned long') [-Wsign-conversion] if (!strncmp("-display", arg, len)) { ~~~~~~~ ^~~ xdpyinfo.c:1468:47: warning: implicit conversion changes signedness: 'int' to 'size_t' (aka 'unsigned long') [-Wsign-conversion] } else if (!strncmp("-queryExtensions", arg, len)) { ~~~~~~~ ^~~ xdpyinfo.c:1470:35: warning: implicit conversion changes signedness: 'int' to 'size_t' (aka 'unsigned long') [-Wsign-conversion] } else if (!strncmp("-ext", arg, len)) { ~~~~~~~ ^~~ Signed-off-by: Alan Coopersmith --- xdpyinfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xdpyinfo.c b/xdpyinfo.c index fdf2515..c08748c 100644 --- a/xdpyinfo.c +++ b/xdpyinfo.c @@ -1460,7 +1460,7 @@ main(int argc, char *argv[]) for (i = 1; i < argc; i++) { char *arg = argv[i]; - int len = strlen(arg); + size_t len = strlen(arg); if (!strncmp("-display", arg, len)) { if (++i >= argc) usage (); -- 2.7.4