From f3e76dcae3dc6fff5e0d3d0932a1287c9337466c Mon Sep 17 00:00:00 2001
From: Ahmed Bougacha <ahmed@bougacha.org>
Date: Tue, 12 Apr 2022 09:39:03 -0700
Subject: [PATCH] [AArch64] Cleanup call-rv-marker.ll test. NFC.

This was doing -iphoneos instead of -ios. While there,
remove an old TODO and cleanup some alignment.
---
 llvm/test/CodeGen/AArch64/call-rv-marker.ll | 72 ++++++++++++++---------------
 1 file changed, 34 insertions(+), 38 deletions(-)

diff --git a/llvm/test/CodeGen/AArch64/call-rv-marker.ll b/llvm/test/CodeGen/AArch64/call-rv-marker.ll
index cb040c6..4c97839 100644
--- a/llvm/test/CodeGen/AArch64/call-rv-marker.ll
+++ b/llvm/test/CodeGen/AArch64/call-rv-marker.ll
@@ -1,9 +1,8 @@
 ; RUN: llc -o - %s | FileCheck --check-prefix=SELDAG --check-prefix=CHECK %s
 ; RUN: llc -global-isel -o - %s | FileCheck --check-prefix=GISEL --check-prefix=CHECK %s
 
-; TODO: support marker generation with GlobalISel
 target datalayout = "e-m:e-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128"
-target triple = "arm64-apple-iphoneos"
+target triple = "arm64-apple-ios"
 
 declare i8* @foo0(i32)
 declare i8* @foo1()
@@ -26,11 +25,10 @@ declare void @llvm.lifetime.end.p0i8(i64 immarg, i8* nocapture)
 @fptr = dso_local global i8* ()* null, align 8
 
 define dso_local i8* @rv_marker_1_retain() {
-; CHECK-LABEL:    rv_marker_1_retain:
-; CHECK:           .cfi_offset w30, -16
-; CHECK-NEXT:      bl foo1
-; CHECK-NEXT:     mov x29, x29
-; CHECK-NEXT:     bl objc_retainAutoreleasedReturnValue
+; CHECK-LABEL: _rv_marker_1_retain:
+; CHECK:         bl _foo1
+; CHECK-NEXT:    mov x29, x29
+; CHECK-NEXT:    bl _objc_retainAutoreleasedReturnValue
 ;
 entry:
   %call = call i8* @foo1() [ "clang.arc.attachedcall"(i8* (i8*)* @objc_retainAutoreleasedReturnValue) ]
@@ -38,11 +36,10 @@ entry:
 }
 
 define dso_local i8* @rv_marker_1_unsafeClaim() {
-; CHECK-LABEL:    rv_marker_1_unsafeClaim:
-; CHECK:           .cfi_offset w30, -16
-; CHECK-NEXT:      bl foo1
-; CHECK-NEXT:     mov x29, x29
-; CHECK-NEXT:     bl objc_unsafeClaimAutoreleasedReturnValue
+; CHECK-LABEL: _rv_marker_1_unsafeClaim:
+; CHECK:         bl _foo1
+; CHECK-NEXT:    mov x29, x29
+; CHECK-NEXT:    bl _objc_unsafeClaimAutoreleasedReturnValue
 ;
 entry:
   %call = call i8* @foo1() [ "clang.arc.attachedcall"(i8* (i8*)* @objc_unsafeClaimAutoreleasedReturnValue) ]
@@ -50,14 +47,14 @@ entry:
 }
 
 define dso_local void @rv_marker_2_select(i32 %c) {
-; CHECK-LABEL: rv_marker_2_select:
+; CHECK-LABEL: _rv_marker_2_select:
 ; SELDAG:        cinc  w0, w8, eq
 ; GISEL:         csinc w0, w8, wzr, eq
-; CHECK-NEXT:    bl  foo0
-; CHECK-NEXT:   mov x29, x29
-; CHECK-NEXT:   bl objc_retainAutoreleasedReturnValue
-; CHECK-NEXT:    ldr x30, [sp], #16
-; CHECK-NEXT:    b  foo2
+; CHECK-NEXT:    bl _foo0
+; CHECK-NEXT:    mov x29, x29
+; CHECK-NEXT:    bl _objc_retainAutoreleasedReturnValue
+; CHECK-NEXT:    ldp x29, x30, [sp], #16
+; CHECK-NEXT:    b _foo2
 ;
 entry:
   %tobool.not = icmp eq i32 %c, 0
@@ -68,11 +65,10 @@ entry:
 }
 
 define dso_local void @rv_marker_3() personality i8* bitcast (i32 (...)* @__gxx_personality_v0 to i8*) {
-; CHECK-LABEL: rv_marker_3
-; CHECK:         .cfi_offset w30, -32
-; CHECK-NEXT:    bl  foo1
-; CHECK-NEXT:   mov x29, x29
-; CHECK-NEXT:   bl objc_retainAutoreleasedReturnValue
+; CHECK-LABEL: _rv_marker_3:
+; CHECK:         bl _foo1
+; CHECK-NEXT:    mov x29, x29
+; CHECK-NEXT:    bl _objc_retainAutoreleasedReturnValue
 ;
 entry:
   %call = call i8* @foo1() [ "clang.arc.attachedcall"(i8* (i8*)* @objc_retainAutoreleasedReturnValue) ]
@@ -91,12 +87,12 @@ lpad:                                             ; preds = %entry
 }
 
 define dso_local void @rv_marker_4() personality i8* bitcast (i32 (...)* @__gxx_personality_v0 to i8*) {
-; CHECK-LABEL: rv_marker_4
-; CHECK:       .Ltmp3:
-; CHECK-NEXT:     bl  foo1
+; CHECK-LABEL: _rv_marker_4:
+; CHECK:       Ltmp3:
+; CHECK-NEXT:    bl _foo1
 ; CHECK-NEXT:    mov x29, x29
-; CHECK-NEXT:    bl objc_retainAutoreleasedReturnValue
-; CHECK-NEXT: .Ltmp4:
+; CHECK-NEXT:    bl _objc_retainAutoreleasedReturnValue
+; CHECK-NEXT:  Ltmp4:
 ;
 entry:
   %s = alloca %struct.S, align 1
@@ -134,11 +130,11 @@ ehcleanup:                                        ; preds = %lpad1, %lpad
 }
 
 define dso_local i8* @rv_marker_5_indirect_call() {
-; CHECK-LABEL: rv_marker_5_indirect_call
+; CHECK-LABEL: _rv_marker_5_indirect_call:
 ; CHECK:         ldr [[ADDR:x[0-9]+]], [
 ; CHECK-NEXT:    blr [[ADDR]]
-; CHECK-NEXT:   mov x29, x29
-; CHECK-NEXT:   bl objc_retainAutoreleasedReturnValue
+; CHECK-NEXT:    mov x29, x29
+; CHECK-NEXT:    bl _objc_retainAutoreleasedReturnValue
 entry:
   %0 = load i8* ()*, i8* ()** @fptr, align 8
   %call = call i8* %0() [ "clang.arc.attachedcall"(i8* (i8*)* @objc_retainAutoreleasedReturnValue) ]
@@ -149,13 +145,13 @@ entry:
 declare i8* @foo(i64, i64, i64)
 
 define dso_local void @rv_marker_multiarg(i64 %a, i64 %b, i64 %c) {
-; CHECK-LABEL: rv_marker_multiarg
-; CHECK:        mov [[TMP:x[0-9]+]], x0
-; CHECK-NEXT:   mov x0, x2
-; CHECK-NEXT:   mov x2, [[TMP]]
-; CHECK-NEXT:   bl  foo
-; CHECK-NEXT:  mov x29, x29
-; CHECK-NEXT:  bl objc_retainAutoreleasedReturnValue
+; CHECK-LABEL: _rv_marker_multiarg:
+; CHECK:         mov [[TMP:x[0-9]+]], x0
+; CHECK-NEXT:    mov x0, x2
+; CHECK-NEXT:    mov x2, [[TMP]]
+; CHECK-NEXT:    bl  _foo
+; CHECK-NEXT:    mov x29, x29
+; CHECK-NEXT:    bl _objc_retainAutoreleasedReturnValue
   call i8* @foo(i64 %c, i64 %b, i64 %a) [ "clang.arc.attachedcall"(i8* (i8*)* @objc_retainAutoreleasedReturnValue) ]
   ret void
 }
-- 
2.7.4