From f3bd362a1857c617a4154062cadd501fc52c4199 Mon Sep 17 00:00:00 2001 From: Jes Sorensen Date: Mon, 24 Jan 2011 16:33:28 +0100 Subject: [PATCH] strtosz(): use unsigned char and switch to qemu_isspace() isspace() behavior is undefined for signed char. Bug pointed out by Eric Blake, thanks! Signed-off-by: Jes Sorensen Signed-off-by: Kevin Wolf --- cutils.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/cutils.c b/cutils.c index 4d2e27c13a..a067cf45b3 100644 --- a/cutils.c +++ b/cutils.c @@ -294,7 +294,8 @@ int fcntl_setfl(int fd, int flag) int64_t strtosz_suffix(const char *nptr, char **end, const char default_suffix) { int64_t retval = -1; - char *endptr, c, d; + char *endptr; + unsigned char c, d; int mul_required = 0; double val, mul, integral, fraction; @@ -314,7 +315,7 @@ int64_t strtosz_suffix(const char *nptr, char **end, const char default_suffix) */ c = *endptr; d = c; - if (isspace(c) || c == '\0' || c == ',') { + if (qemu_isspace(c) || c == '\0' || c == ',') { c = 0; if (default_suffix) { d = default_suffix; @@ -361,7 +362,7 @@ int64_t strtosz_suffix(const char *nptr, char **end, const char default_suffix) */ if (c != 0) { endptr++; - if (!isspace(*endptr) && *endptr != ',' && *endptr != 0) { + if (!qemu_isspace(*endptr) && *endptr != ',' && *endptr != 0) { goto fail; } } -- 2.34.1