From f2e4ba0e3d40b9f3d5630dcda5e82b1a98f28410 Mon Sep 17 00:00:00 2001 From: serge-sans-paille Date: Fri, 21 Oct 2022 20:49:52 +0200 Subject: [PATCH] Avoid repeated checks and context lookup in llvm::Instruction::getAAMetadata Repeated call to Instruction::hasMetadata() and lookup in getContext().pImpl->ValueMetadata are not needed when we always work on the same instruction, avoid them. This simple change leads to interesting and consistent speedups in compile time, around -0.5% according to http://llvm-compile-time-tracker.com, see http://llvm-compile-time-tracker.com/compare.php?from=9708d88017d0c9adaea65a4f5a5b589b67f292e2&to=88482b9addd5917e9c5226847efeb5451c5f78c0&stat=instructions Differential Revision: https://reviews.llvm.org/D136503 --- llvm/lib/IR/Metadata.cpp | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/llvm/lib/IR/Metadata.cpp b/llvm/lib/IR/Metadata.cpp index fe7d9c1..052f3b1 100644 --- a/llvm/lib/IR/Metadata.cpp +++ b/llvm/lib/IR/Metadata.cpp @@ -1461,10 +1461,15 @@ void Instruction::addAnnotationMetadata(StringRef Name) { AAMDNodes Instruction::getAAMetadata() const { AAMDNodes Result; - Result.TBAA = getMetadata(LLVMContext::MD_tbaa); - Result.TBAAStruct = getMetadata(LLVMContext::MD_tbaa_struct); - Result.Scope = getMetadata(LLVMContext::MD_alias_scope); - Result.NoAlias = getMetadata(LLVMContext::MD_noalias); + // Not using Instruction::hasMetadata() because we're not interested in + // DebugInfoMetadata. + if (Value::hasMetadata()) { + const auto &Info = getContext().pImpl->ValueMetadata[this]; + Result.TBAA = Info.lookup(LLVMContext::MD_tbaa); + Result.TBAAStruct = Info.lookup(LLVMContext::MD_tbaa_struct); + Result.Scope = Info.lookup(LLVMContext::MD_alias_scope); + Result.NoAlias = Info.lookup(LLVMContext::MD_noalias); + } return Result; } -- 2.7.4