From f2dc6492edd47621a14622023e08a661dcd9640c Mon Sep 17 00:00:00 2001 From: Alexander Kornienko Date: Mon, 22 May 2017 14:30:14 +0000 Subject: [PATCH] [clang-tidy] misc-move-const-arg shouldn't complain on std::move(lambda) llvm-svn: 303554 --- clang-tools-extra/clang-tidy/misc/MoveConstantArgumentCheck.cpp | 6 ++++++ clang-tools-extra/test/clang-tidy/misc-move-const-arg.cpp | 3 +++ 2 files changed, 9 insertions(+) diff --git a/clang-tools-extra/clang-tidy/misc/MoveConstantArgumentCheck.cpp b/clang-tools-extra/clang-tidy/misc/MoveConstantArgumentCheck.cpp index c8ef942..cc2d353 100644 --- a/clang-tools-extra/clang-tidy/misc/MoveConstantArgumentCheck.cpp +++ b/clang-tools-extra/clang-tidy/misc/MoveConstantArgumentCheck.cpp @@ -74,6 +74,12 @@ void MoveConstantArgumentCheck::check(const MatchFinder::MatchResult &Result) { if (IsConstArg || IsTriviallyCopyable) { if (const CXXRecordDecl *R = Arg->getType()->getAsCXXRecordDecl()) { + // According to [expr.prim.lambda]p3, "whether the closure type is + // trivially copyable" property can be changed by the implementation of + // the language, so we shouldn't rely on it when issuing diagnostics. + if (R->isLambda()) + return; + // Don't warn when the type is not copyable. for (const auto *Ctor : R->ctors()) { if (Ctor->isCopyConstructor() && Ctor->isDeleted()) return; diff --git a/clang-tools-extra/test/clang-tidy/misc-move-const-arg.cpp b/clang-tools-extra/test/clang-tidy/misc-move-const-arg.cpp index 096f2f9..29b2b92 100644 --- a/clang-tools-extra/test/clang-tidy/misc-move-const-arg.cpp +++ b/clang-tools-extra/test/clang-tidy/misc-move-const-arg.cpp @@ -157,6 +157,9 @@ void moveToConstReferenceNegatives() { // No warning inside of macro expansion, even if the macro expansion is inside // a lambda that is, in turn, an argument to a macro. CALL([no_move_semantics] { M3(NoMoveSemantics, no_move_semantics); }); + + auto lambda = [] {}; + auto lambda2 = std::move(lambda); } class MoveOnly { -- 2.7.4