From f2d393d49a9e7e8c9cc6ceb3c4005b2d0dc7aca7 Mon Sep 17 00:00:00 2001 From: tasn Date: Mon, 5 Mar 2012 13:24:04 +0000 Subject: [PATCH] Elm: Added XXX to the sources. I'm against it, but raster asked nicely... git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/elementary@68717 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33 --- src/lib/Elementary.h.in | 6 +++--- src/lib/elc_anchorblock.h | 2 ++ src/lib/elc_anchorview.h | 2 ++ src/lib/elc_ctxpopup.h | 2 ++ src/lib/elc_fileselector_button.h | 1 + src/lib/elc_hoversel.h | 1 + src/lib/elc_multibuttonentry.h | 7 +++++++ src/lib/elc_naviframe.h | 4 ++++ src/lib/elm_bg.h | 1 + src/lib/elm_entry.h | 2 ++ 10 files changed, 25 insertions(+), 3 deletions(-) diff --git a/src/lib/Elementary.h.in b/src/lib/Elementary.h.in index 7afde05..7bbc108 100644 --- a/src/lib/Elementary.h.in +++ b/src/lib/Elementary.h.in @@ -172,10 +172,10 @@ EAPI extern Elm_Version *elm_version; #include #include #include -#include -#include +#include //ok +#include //ok #include -#include +#include //ok // Daniel Juyung Seo #include // OK diff --git a/src/lib/elc_anchorblock.h b/src/lib/elc_anchorblock.h index 6d24699..0d49db8 100644 --- a/src/lib/elc_anchorblock.h +++ b/src/lib/elc_anchorblock.h @@ -37,6 +37,8 @@ * @{ */ +/* XXX: Remove this awful widget. */ + /** * @typedef Elm_Entry_Anchorblock_Info * diff --git a/src/lib/elc_anchorview.h b/src/lib/elc_anchorview.h index 4a4516b..d70c1e4 100644 --- a/src/lib/elc_anchorview.h +++ b/src/lib/elc_anchorview.h @@ -41,6 +41,8 @@ */ typedef struct _Elm_Entry_Anchorview_Info Elm_Entry_Anchorview_Info; +/* XXX: Merge into entry. */ + /** * @struct _Elm_Entry_Anchorview_Info * diff --git a/src/lib/elc_ctxpopup.h b/src/lib/elc_ctxpopup.h index 240501b..1e6ede7 100644 --- a/src/lib/elc_ctxpopup.h +++ b/src/lib/elc_ctxpopup.h @@ -46,6 +46,8 @@ * @{ */ +/* XXX: Kinda internal, but relevant for the theme: use elm_scroller and not els_scroller. */ + typedef enum { ELM_CTXPOPUP_DIRECTION_DOWN, /**< ctxpopup show appear below clicked area */ diff --git a/src/lib/elc_fileselector_button.h b/src/lib/elc_fileselector_button.h index 73c9651..125c098 100644 --- a/src/lib/elc_fileselector_button.h +++ b/src/lib/elc_fileselector_button.h @@ -63,6 +63,7 @@ */ EAPI Evas_Object *elm_fileselector_button_add(Evas_Object *parent); +/* XXX: fileselector/fs_button/fs_entry: elm_fileselector_expandable_set should probably be called: tree_view or something. */ /** * Set the title for a given file selector button widget's window * diff --git a/src/lib/elc_hoversel.h b/src/lib/elc_hoversel.h index ca16733..827c973 100644 --- a/src/lib/elc_hoversel.h +++ b/src/lib/elc_hoversel.h @@ -77,6 +77,7 @@ EAPI Eina_Bool elm_hoversel_horizontal_get(const Evas_Object * hoversel is clicked. Should probably be the window that the hoversel is * in. See @ref Hover objects for more information. */ +/* XXX: Not the best name in my pov. Maybe call it tree_view or something. */ EAPI void elm_hoversel_hover_parent_set(Evas_Object *obj, Evas_Object *parent); /** * @brief Get the Hover parent diff --git a/src/lib/elc_multibuttonentry.h b/src/lib/elc_multibuttonentry.h index 03e8981..dcf3f19 100644 --- a/src/lib/elc_multibuttonentry.h +++ b/src/lib/elc_multibuttonentry.h @@ -37,6 +37,13 @@ * */ +/* XXX: + * 1. docs are lacking. + * 2. name sucks + * 3. should use the elm_object_part_text_set to set guide text. + * 4. shrink_mode is an awful name. + * 5. bugs: offset bug with the "tap to add recipient" + delete doesn't delete items but backspace does. */ + /** * @addtogroup Multibuttonentry * @{ diff --git a/src/lib/elc_naviframe.h b/src/lib/elc_naviframe.h index 063b9eb..2a22628 100644 --- a/src/lib/elc_naviframe.h +++ b/src/lib/elc_naviframe.h @@ -69,6 +69,10 @@ * @{ */ +/* XXX: docs are incomplete. for example: pop_to + elm_naviframe_content_preserve_on_pop_set sounds like the hackiest thing ever. + * all the api looks like it was created as workarounds for issues instead of designed from the start. - really, everything should be rewritten. + */ + /** * @brief Add a new Naviframe object to the parent. * diff --git a/src/lib/elm_bg.h b/src/lib/elm_bg.h index 0feff07..a378117 100644 --- a/src/lib/elm_bg.h +++ b/src/lib/elm_bg.h @@ -141,6 +141,7 @@ EAPI void elm_bg_color_get(const Evas_Object *obj, int * * * @ingroup Bg */ +/* XXX: Sounds awfully hackish - there must be a better way than hardcoding pixel sizes. Do they at least scale with the config? */ EAPI void elm_bg_load_size_set(Evas_Object *obj, Evas_Coord w, Evas_Coord h); /** diff --git a/src/lib/elm_entry.h b/src/lib/elm_entry.h index 261ee98..b9ca59e 100644 --- a/src/lib/elm_entry.h +++ b/src/lib/elm_entry.h @@ -253,6 +253,8 @@ typedef enum ELM_TEXT_FORMAT_MARKUP_UTF8 /**< Markup UTF8 type */ } Elm_Text_Format; +/* XXX: Filter_Limit_Size and Filter_Accept_Set are awful in my pov. The API looks bad. */ + /** * @enum _Elm_Wrap_Type * @typedef Elm_Wrap_Type -- 2.7.4