From f2aa0e80a0c392b407f59ded6c10e4504d96fc6c Mon Sep 17 00:00:00 2001 From: Samuel Pitoiset Date: Wed, 22 Feb 2023 16:36:11 +0100 Subject: [PATCH] radv: enable fullyCoveredFragmentShaderInputVariable on GFX9+ For vkd3d-proton Tier 3. It's passing CTS and vkd3d-proton tests. Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8311 Signed-off-by: Samuel Pitoiset Part-of: --- docs/relnotes/new_features.txt | 1 + src/amd/ci/radv-navi21-aco-fails.txt | 11 +++++++++++ src/amd/ci/radv-vangogh-aco-fails.txt | 11 +++++++++++ src/amd/vulkan/radv_physical_device.c | 2 +- src/amd/vulkan/radv_shader.c | 1 + 5 files changed, 25 insertions(+), 1 deletion(-) diff --git a/docs/relnotes/new_features.txt b/docs/relnotes/new_features.txt index 58aafc1..60cd053 100644 --- a/docs/relnotes/new_features.txt +++ b/docs/relnotes/new_features.txt @@ -1,3 +1,4 @@ VK_EXT_pipeline_library_group_handles on RADV VK_EXT_image_sliced_view_of_3d on RADV/GFX10+ VK_KHR_map_memory2 on ANV +fullyCoveredFragmentShaderInputVariable on RADV/GFX9+ diff --git a/src/amd/ci/radv-navi21-aco-fails.txt b/src/amd/ci/radv-navi21-aco-fails.txt index faa38e3..91d2cb5 100644 --- a/src/amd/ci/radv-navi21-aco-fails.txt +++ b/src/amd/ci/radv-navi21-aco-fails.txt @@ -115,3 +115,14 @@ dEQP-VK.binding_model.descriptor_buffer.multiple.graphics_vert_buffers32_sets1,C dEQP-VK.binding_model.descriptor_buffer.multiple.graphics_vert_buffers3_sets1,Crash dEQP-VK.binding_model.descriptor_buffer.multiple.graphics_vert_buffers8_sets1,Crash dEQP-VK.pipeline.fast_linked_library.extended_dynamic_state.before_draw.line_stipple_enable,Fail + +# https://gitlab.khronos.org/Tracker/vk-gl-cts/-/issues/4298 +dEQP-VK.pipeline.fast_linked_library.multisample_with_fragment_shading_rate.conservative_with_full_coverage.underestimate.samples_2_post_depth_coverage,Fail +dEQP-VK.pipeline.fast_linked_library.multisample_with_fragment_shading_rate.conservative_with_full_coverage.underestimate.samples_4_post_depth_coverage,Fail +dEQP-VK.pipeline.fast_linked_library.multisample_with_fragment_shading_rate.conservative_with_full_coverage.underestimate.samples_8_post_depth_coverage,Fail +dEQP-VK.pipeline.monolithic.multisample_with_fragment_shading_rate.conservative_with_full_coverage.underestimate.samples_2_post_depth_coverage,Fail +dEQP-VK.pipeline.monolithic.multisample_with_fragment_shading_rate.conservative_with_full_coverage.underestimate.samples_4_post_depth_coverage,Fail +dEQP-VK.pipeline.monolithic.multisample_with_fragment_shading_rate.conservative_with_full_coverage.underestimate.samples_8_post_depth_coverage,Fail +dEQP-VK.pipeline.pipeline_library.multisample_with_fragment_shading_rate.conservative_with_full_coverage.underestimate.samples_2_post_depth_coverage,Fail +dEQP-VK.pipeline.pipeline_library.multisample_with_fragment_shading_rate.conservative_with_full_coverage.underestimate.samples_4_post_depth_coverage,Fail +dEQP-VK.pipeline.pipeline_library.multisample_with_fragment_shading_rate.conservative_with_full_coverage.underestimate.samples_8_post_depth_coverage,Fail diff --git a/src/amd/ci/radv-vangogh-aco-fails.txt b/src/amd/ci/radv-vangogh-aco-fails.txt index 979ffc1..3fce2d3 100644 --- a/src/amd/ci/radv-vangogh-aco-fails.txt +++ b/src/amd/ci/radv-vangogh-aco-fails.txt @@ -117,3 +117,14 @@ dEQP-VK.binding_model.descriptor_buffer.multiple.graphics_vert_buffers8_sets1,Cr dEQP-VK.binding_model.ics_miss_buffers8_sets1,Crash dEQP-VK.draw.dynamic_rendering.primary_cmd_buff.linear_interpolation.no_offset_2_samples,Fail + +# https://gitlab.khronos.org/Tracker/vk-gl-cts/-/issues/4298 +dEQP-VK.pipeline.fast_linked_library.multisample_with_fragment_shading_rate.conservative_with_full_coverage.underestimate.samples_2_post_depth_coverage,Fail +dEQP-VK.pipeline.fast_linked_library.multisample_with_fragment_shading_rate.conservative_with_full_coverage.underestimate.samples_4_post_depth_coverage,Fail +dEQP-VK.pipeline.fast_linked_library.multisample_with_fragment_shading_rate.conservative_with_full_coverage.underestimate.samples_8_post_depth_coverage,Fail +dEQP-VK.pipeline.monolithic.multisample_with_fragment_shading_rate.conservative_with_full_coverage.underestimate.samples_2_post_depth_coverage,Fail +dEQP-VK.pipeline.monolithic.multisample_with_fragment_shading_rate.conservative_with_full_coverage.underestimate.samples_4_post_depth_coverage,Fail +dEQP-VK.pipeline.monolithic.multisample_with_fragment_shading_rate.conservative_with_full_coverage.underestimate.samples_8_post_depth_coverage,Fail +dEQP-VK.pipeline.pipeline_library.multisample_with_fragment_shading_rate.conservative_with_full_coverage.underestimate.samples_2_post_depth_coverage,Fail +dEQP-VK.pipeline.pipeline_library.multisample_with_fragment_shading_rate.conservative_with_full_coverage.underestimate.samples_4_post_depth_coverage,Fail +dEQP-VK.pipeline.pipeline_library.multisample_with_fragment_shading_rate.conservative_with_full_coverage.underestimate.samples_8_post_depth_coverage,Fail diff --git a/src/amd/vulkan/radv_physical_device.c b/src/amd/vulkan/radv_physical_device.c index 731974d..9871a2b 100644 --- a/src/amd/vulkan/radv_physical_device.c +++ b/src/amd/vulkan/radv_physical_device.c @@ -1840,7 +1840,7 @@ radv_GetPhysicalDeviceProperties2(VkPhysicalDevice physicalDevice, properties->conservativePointAndLineRasterization = false; properties->degenerateTrianglesRasterized = true; properties->degenerateLinesRasterized = false; - properties->fullyCoveredFragmentShaderInputVariable = false; + properties->fullyCoveredFragmentShaderInputVariable = true; properties->conservativeRasterizationPostDepthCoverage = false; break; } diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c index 2ff3ca0..9c1e039 100644 --- a/src/amd/vulkan/radv_shader.c +++ b/src/amd/vulkan/radv_shader.c @@ -716,6 +716,7 @@ radv_shader_spirv_to_nir(struct radv_device *device, const struct radv_pipeline_ .float32_atomic_min_max = true, .float64 = true, .float64_atomic_min_max = true, + .fragment_fully_covered = true, .geometry_streams = true, .groups = true, .image_atomic_int64 = true, -- 2.7.4