From f25c5b88b061623e5fc4907e646b05db011fbe6f Mon Sep 17 00:00:00 2001 From: Hyuntae Kim Date: Thu, 23 Apr 2020 07:53:17 +0900 Subject: [PATCH] fix svace issue list Change-Id: Idb46079214bcd620a94d80945abd557189c6f16e --- packaging/libmm-camcorder.spec | 2 +- src/mm_camcorder_exifinfo.c | 2 +- src/mm_camcorder_internal.c | 7 ++----- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/packaging/libmm-camcorder.spec b/packaging/libmm-camcorder.spec index f7f92a6..269857a 100644 --- a/packaging/libmm-camcorder.spec +++ b/packaging/libmm-camcorder.spec @@ -1,6 +1,6 @@ Name: libmm-camcorder Summary: Camera and recorder library -Version: 0.10.198 +Version: 0.10.199 Release: 0 Group: Multimedia/Libraries License: Apache-2.0 diff --git a/src/mm_camcorder_exifinfo.c b/src/mm_camcorder_exifinfo.c index 8019984..46e7cc5 100644 --- a/src/mm_camcorder_exifinfo.c +++ b/src/mm_camcorder_exifinfo.c @@ -164,7 +164,7 @@ mm_exif_get_exif_from_info(mm_exif_info_t *info) size[1] = (unsigned char) (info->size >> 8); exif_loader_write(loader, size, 2); - for (i = 0; i < info->size && exif_loader_write(loader, info->data + i, 1); i++); + for (i = 0; i < info->size && exif_loader_write(loader, (unsigned char *)(info->data) + i, 1); i++); ed = exif_loader_get_data(loader); exif_loader_unref(loader); diff --git a/src/mm_camcorder_internal.c b/src/mm_camcorder_internal.c index 200b068..454e236 100644 --- a/src/mm_camcorder_internal.c +++ b/src/mm_camcorder_internal.c @@ -2343,7 +2343,7 @@ _MMCamcorderSubContext *_mmcamcorder_alloc_subcontext(int type) /* alloc container */ sc = (_MMCamcorderSubContext *)malloc(sizeof(_MMCamcorderSubContext)); - mmf_return_val_if_fail(sc != NULL, NULL); + mmf_return_val_if_fail(sc, NULL); /* init members */ memset(sc, 0x00, sizeof(_MMCamcorderSubContext)); @@ -2861,7 +2861,6 @@ GstBusSyncReply _mmcamcorder_pipeline_bus_sync_callback(GstBus *bus, GstMessage DROP_MESSAGE: gst_message_unref(message); - message = NULL; return GST_BUS_DROP; } @@ -3050,10 +3049,8 @@ GstBusSyncReply _mmcamcorder_encode_pipeline_bus_sync_callback(GstBus *bus, GstM ret = __mmcamcorder_handle_gst_sync_error(hcamcorder, message); } - if (ret == GST_BUS_DROP) { + if (ret == GST_BUS_DROP) gst_message_unref(message); - message = NULL; - } return ret; } -- 2.34.1