From f240d303c2edf69d6a53691c62da110877ac6bf5 Mon Sep 17 00:00:00 2001 From: River Riddle Date: Fri, 6 Mar 2020 19:18:13 -0800 Subject: [PATCH] [mlir] Explicitly qualify Effect to avoid MSVC build failure MSVC qualifies the Effect reference contextually depending on where the template is instantiated, leading to compiler failures if there is a different Effect class defined. --- mlir/include/mlir/IR/OpDefinition.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mlir/include/mlir/IR/OpDefinition.h b/mlir/include/mlir/IR/OpDefinition.h index fe94f25..a279843 100644 --- a/mlir/include/mlir/IR/OpDefinition.h +++ b/mlir/include/mlir/IR/OpDefinition.h @@ -1301,7 +1301,7 @@ public: static ClassID *getEffectID() { return ClassID::getID(); } /// 'classof' used to support llvm style cast functionality. - static bool classof(const Effect *effect) { + static bool classof(const ::mlir::SideEffects::Effect *effect) { return effect->getEffectID() == BaseT::getEffectID(); } -- 2.7.4