From f22e5869a012af09e130d804bba441eff261b1fe Mon Sep 17 00:00:00 2001 From: Simon Pilgrim Date: Wed, 18 Aug 2021 11:02:39 +0100 Subject: [PATCH] [Sema] CheckObjCBridgeNSCast - fix dead code warning. NFCI. Target is only ever non-null when we find an existing type, so move its declaration inside that case, and remove the dead code where Target was always null. --- clang/lib/Sema/SemaExprObjC.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/clang/lib/Sema/SemaExprObjC.cpp b/clang/lib/Sema/SemaExprObjC.cpp index 8a9c933..9e46801 100644 --- a/clang/lib/Sema/SemaExprObjC.cpp +++ b/clang/lib/Sema/SemaExprObjC.cpp @@ -4015,12 +4015,11 @@ static bool CheckObjCBridgeNSCast(Sema &S, QualType castType, Expr *castExpr, if (Parm->isStr("id")) return true; - NamedDecl *Target = nullptr; // Check for an existing type with this name. LookupResult R(S, DeclarationName(Parm), SourceLocation(), Sema::LookupOrdinaryName); if (S.LookupName(R, S.TUScope)) { - Target = R.getFoundDecl(); + NamedDecl *Target = R.getFoundDecl(); if (Target && isa(Target)) { ObjCInterfaceDecl *ExprClass = cast(Target); if (const ObjCObjectPointerType *InterfacePointerType = @@ -4056,8 +4055,6 @@ static bool CheckObjCBridgeNSCast(Sema &S, QualType castType, Expr *castExpr, diag::err_objc_cf_bridged_not_interface) << castExpr->getType() << Parm; S.Diag(TDNDecl->getBeginLoc(), diag::note_declared_at); - if (Target) - S.Diag(Target->getBeginLoc(), diag::note_declared_at); } return true; } -- 2.7.4