From f1f0625e97a72e78316c54c6d11846e5eccd5ffc Mon Sep 17 00:00:00 2001 From: =?utf8?q?Sebastian=20Dr=C3=B6ge?= Date: Tue, 29 Mar 2011 15:41:33 +0200 Subject: [PATCH] encodebin: Requesting a pad again now gives a g_return_val_if_fail() Before the behaviour was undefined and implemented differently by elements, now core checks for this (and other problems) and returns NULL and an assertion. --- tests/check/elements/encodebin.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/check/elements/encodebin.c b/tests/check/elements/encodebin.c index 03ff262..0d0d009 100644 --- a/tests/check/elements/encodebin.c +++ b/tests/check/elements/encodebin.c @@ -504,7 +504,8 @@ GST_START_TEST (test_encodebin_render_audio_only_static) fail_unless (gst_element_link_many (audiotestsrc, ebin, fakesink, NULL)); /* Requesting a new pad should fail */ - fail_if (gst_element_get_request_pad (ebin, "audio_0") != NULL); + ASSERT_CRITICAL (gst_element_get_request_pad (ebin, "audio_0")); + sinkcaps = gst_caps_new_simple ("audio/x-raw-int", NULL); g_signal_emit_by_name (ebin, "request-pad", sinkcaps, &sinkpad); gst_caps_unref (sinkcaps); -- 2.7.4