From f1cf6e7172ae0f0fc3c4617c810d71c514c5e0ba Mon Sep 17 00:00:00 2001 From: Mike McLaughlin Date: Thu, 20 Sep 2018 21:28:27 -0700 Subject: [PATCH] Fix issue #20076 createdump faults. (#20084) Return E_FAIL instead of S_FALSE from ClrDataFrame::GetLocalSig(). Also issue https://github.com/dotnet/diagnostics/issues/61 --- src/debug/daccess/stack.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/debug/daccess/stack.cpp b/src/debug/daccess/stack.cpp index b235366..2f69a02 100644 --- a/src/debug/daccess/stack.cpp +++ b/src/debug/daccess/stack.cpp @@ -1257,7 +1257,7 @@ ClrDataFrame::GetLocalSig(MetaSig** sig, { *sig = NULL; *count = 0; - return S_FALSE; + return E_FAIL; } COR_ILMETHOD_DECODER methodDecoder(m_methodDesc->GetILHeader()); @@ -1267,7 +1267,7 @@ ClrDataFrame::GetLocalSig(MetaSig** sig, { *sig = NULL; *count = 0; - return S_FALSE; + return E_FAIL; } ULONG tokenSigLen; -- 2.7.4