From f1a7e6203316ef6f84977ce60075a84a47e6f28d Mon Sep 17 00:00:00 2001 From: Matt Arsenault Date: Tue, 15 Jul 2014 01:55:03 +0000 Subject: [PATCH] Teach computeKnownBits to look through addrspacecast. This fixes inferring alignment through an addrspacecast. llvm-svn: 213030 --- llvm/lib/Analysis/ValueTracking.cpp | 2 ++ .../Transforms/InstCombine/loadstore-alignment.ll | 31 +++++++++++++++++++++- 2 files changed, 32 insertions(+), 1 deletion(-) diff --git a/llvm/lib/Analysis/ValueTracking.cpp b/llvm/lib/Analysis/ValueTracking.cpp index bfdc349..cedf076 100644 --- a/llvm/lib/Analysis/ValueTracking.cpp +++ b/llvm/lib/Analysis/ValueTracking.cpp @@ -29,6 +29,7 @@ #include "llvm/IR/Metadata.h" #include "llvm/IR/Operator.h" #include "llvm/IR/PatternMatch.h" +#include "llvm/Support/Debug.h" #include "llvm/Support/MathExtras.h" #include using namespace llvm; @@ -415,6 +416,7 @@ void llvm::computeKnownBits(Value *V, APInt &KnownZero, APInt &KnownOne, break; // Can't work with floating point. case Instruction::PtrToInt: case Instruction::IntToPtr: + case Instruction::AddrSpaceCast: // Pointers could be different sizes. // We can't handle these if we don't know the pointer size. if (!TD) break; // FALL THROUGH and handle them the same as zext/trunc. diff --git a/llvm/test/Transforms/InstCombine/loadstore-alignment.ll b/llvm/test/Transforms/InstCombine/loadstore-alignment.ll index 6a6ac45..e90bdb7 100644 --- a/llvm/test/Transforms/InstCombine/loadstore-alignment.ll +++ b/llvm/test/Transforms/InstCombine/loadstore-alignment.ll @@ -1,9 +1,11 @@ ; RUN: opt -instcombine -S < %s | FileCheck %s -target datalayout = "E-p:64:64:64-a0:0:8-f32:32:32-f64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:64-v64:64:64-v128:128:128" +target datalayout = "E-p:64:64:64-p1:64:64:64-p2:32:32:32-a0:0:8-f32:32:32-f64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:64-v64:64:64-v128:128:128" @x = external global <2 x i64>, align 16 @xx = external global [13 x <2 x i64>], align 16 +@x.as2 = external addrspace(2) global <2 x i64>, align 16 + ; CHECK-LABEL: @static_hem( ; CHECK: , align 16 define <2 x i64> @static_hem() { @@ -12,6 +14,33 @@ define <2 x i64> @static_hem() { ret <2 x i64> %tmp1 } +; CHECK-LABEL: @static_hem_addrspacecast( +; CHECK: , align 16 +define <2 x i64> @static_hem_addrspacecast() { + %t = getelementptr <2 x i64>* @x, i32 7 + %t.asc = addrspacecast <2 x i64>* %t to <2 x i64> addrspace(1)* + %tmp1 = load <2 x i64> addrspace(1)* %t.asc, align 1 + ret <2 x i64> %tmp1 +} + +; CHECK-LABEL: @static_hem_addrspacecast_smaller_ptr( +; CHECK: , align 16 +define <2 x i64> @static_hem_addrspacecast_smaller_ptr() { + %t = getelementptr <2 x i64>* @x, i32 7 + %t.asc = addrspacecast <2 x i64>* %t to <2 x i64> addrspace(2)* + %tmp1 = load <2 x i64> addrspace(2)* %t.asc, align 1 + ret <2 x i64> %tmp1 +} + +; CHECK-LABEL: @static_hem_addrspacecast_larger_ptr( +; CHECK: , align 16 +define <2 x i64> @static_hem_addrspacecast_larger_ptr() { + %t = getelementptr <2 x i64> addrspace(2)* @x.as2, i32 7 + %t.asc = addrspacecast <2 x i64> addrspace(2)* %t to <2 x i64> addrspace(1)* + %tmp1 = load <2 x i64> addrspace(1)* %t.asc, align 1 + ret <2 x i64> %tmp1 +} + ; CHECK-LABEL: @hem( ; CHECK: , align 16 define <2 x i64> @hem(i32 %i) { -- 2.7.4