From f1971fe1e985494ab1341463f02a13226fb233bf Mon Sep 17 00:00:00 2001 From: Rico Tzschichholz Date: Tue, 10 Sep 2013 16:39:30 +0100 Subject: [PATCH] controlbindings: fix pspec relaxation for control source properties The change should have been from PARAM_CONSTRUCT_ONLY to PARAM_CONSTRUCT, otherwise bindings are affected, since they look for the CONSTRUCT flag. See ec55363d --- libs/gst/controller/gstargbcontrolbinding.c | 12 ++++++++---- libs/gst/controller/gstdirectcontrolbinding.c | 3 ++- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/libs/gst/controller/gstargbcontrolbinding.c b/libs/gst/controller/gstargbcontrolbinding.c index 10506ee..cdf879b 100644 --- a/libs/gst/controller/gstargbcontrolbinding.c +++ b/libs/gst/controller/gstargbcontrolbinding.c @@ -104,22 +104,26 @@ gst_argb_control_binding_class_init (GstARGBControlBindingClass * klass) properties[PROP_CS_A] = g_param_spec_object ("control-source-a", "ControlSource A", "The control source for the alpha color component", - GST_TYPE_CONTROL_SOURCE, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS); + GST_TYPE_CONTROL_SOURCE, + G_PARAM_READWRITE | G_PARAM_CONSTRUCT | G_PARAM_STATIC_STRINGS); properties[PROP_CS_R] = g_param_spec_object ("control-source-r", "ControlSource R", "The control source for the red color component", - GST_TYPE_CONTROL_SOURCE, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS); + GST_TYPE_CONTROL_SOURCE, + G_PARAM_READWRITE | G_PARAM_CONSTRUCT | G_PARAM_STATIC_STRINGS); properties[PROP_CS_G] = g_param_spec_object ("control-source-g", "ControlSource G", "The control source for the green color component", - GST_TYPE_CONTROL_SOURCE, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS); + GST_TYPE_CONTROL_SOURCE, + G_PARAM_READWRITE | G_PARAM_CONSTRUCT | G_PARAM_STATIC_STRINGS); properties[PROP_CS_B] = g_param_spec_object ("control-source-b", "ControlSource B", "The control source for the blue color component", - GST_TYPE_CONTROL_SOURCE, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS); + GST_TYPE_CONTROL_SOURCE, + G_PARAM_READWRITE | G_PARAM_CONSTRUCT | G_PARAM_STATIC_STRINGS); g_object_class_install_properties (gobject_class, PROP_LAST, properties); } diff --git a/libs/gst/controller/gstdirectcontrolbinding.c b/libs/gst/controller/gstdirectcontrolbinding.c index ca173b0..9c2e626 100644 --- a/libs/gst/controller/gstdirectcontrolbinding.c +++ b/libs/gst/controller/gstdirectcontrolbinding.c @@ -177,7 +177,8 @@ gst_direct_control_binding_class_init (GstDirectControlBindingClass * klass) properties[PROP_CS] = g_param_spec_object ("control-source", "ControlSource", "The control source", - GST_TYPE_CONTROL_SOURCE, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS); + GST_TYPE_CONTROL_SOURCE, + G_PARAM_READWRITE | G_PARAM_CONSTRUCT | G_PARAM_STATIC_STRINGS); g_object_class_install_properties (gobject_class, PROP_LAST, properties); } -- 2.7.4