From f0d3761f737211f64ec117ce963d402603a739a3 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Jos=C3=A9=20Exp=C3=B3sito?= Date: Fri, 24 Sep 2021 19:06:53 +0200 Subject: [PATCH] libinput: add hold to get base event MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit LIBINPUT_EVENT_GESTURE_HOLD_BEGIN and LIBINPUT_EVENT_GESTURE_HOLD_END were missing from libinput_event_gesture_get_base_event. Add them to avoid triggering an erroneous client bug warning. Fix #671 Signed-off-by: José Expósito --- src/libinput.c | 4 +++- test/test-misc.c | 5 ++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/libinput.c b/src/libinput.c index a0c8504..f985b79 100644 --- a/src/libinput.c +++ b/src/libinput.c @@ -3567,7 +3567,9 @@ libinput_event_gesture_get_base_event(struct libinput_event_gesture *event) LIBINPUT_EVENT_GESTURE_SWIPE_END, LIBINPUT_EVENT_GESTURE_PINCH_BEGIN, LIBINPUT_EVENT_GESTURE_PINCH_UPDATE, - LIBINPUT_EVENT_GESTURE_PINCH_END); + LIBINPUT_EVENT_GESTURE_PINCH_END, + LIBINPUT_EVENT_GESTURE_HOLD_BEGIN, + LIBINPUT_EVENT_GESTURE_HOLD_END); return &event->base; } diff --git a/test/test-misc.c b/test/test-misc.c index 398faa2..732cb12 100644 --- a/test/test-misc.c +++ b/test/test-misc.c @@ -366,6 +366,9 @@ START_TEST(event_conversion_gesture) litest_touch_down(dev, 0, 70, 30); litest_touch_down(dev, 1, 30, 70); + libinput_dispatch(li); + litest_timeout_gesture_hold(); + for (i = 0; i < 8; i++) { litest_push_event_frame(dev); litest_touch_move(dev, 0, 70 - i * 5, 30 + i * 5); @@ -379,7 +382,7 @@ START_TEST(event_conversion_gesture) type = libinput_event_get_type(event); if (type >= LIBINPUT_EVENT_GESTURE_SWIPE_BEGIN && - type <= LIBINPUT_EVENT_GESTURE_PINCH_END) { + type <= LIBINPUT_EVENT_GESTURE_HOLD_END) { struct libinput_event_gesture *g; struct libinput_event *base; g = libinput_event_get_gesture_event(event); -- 2.7.4