From f0cd42383d11de42b3b8137c27c960b257975418 Mon Sep 17 00:00:00 2001 From: =?utf8?q?=C3=86var=20Arnfj=C3=B6r=C3=B0=20Bjarmason?= Date: Fri, 23 Dec 2011 22:17:35 +0000 Subject: [PATCH] regexp.h: remove completely redundant return statement Remove a redundant return() statement at the end of the get_regex_charset_name function. The "default" case for the above switch statement will always return for us. This was added intentionally in v5.14.0-354-g0984e55 by Jim Cromie, but the rationale for doing so is that we might have a compiler bug here, but we're pretty screwed anyway if switch statements stop working as advertised by the standard so there's no reason to be defensive in this particular case. This is also causing a lot of whine from Sun Studio 12 Update 1: regexp.h", line 329: warning: statement not reached --- regexp.h | 1 - 1 file changed, 1 deletion(-) diff --git a/regexp.h b/regexp.h index 5776a90..5ee6448 100644 --- a/regexp.h +++ b/regexp.h @@ -326,7 +326,6 @@ get_regex_charset_name(const U32 flags, STRLEN* const lenp) default: return "?"; /* Unknown */ } - return "?"; /* Unknown */ } /* Anchor and GPOS related stuff */ -- 2.7.4