From f07834abdab4cbc8168625c387dba5cb1ebde939 Mon Sep 17 00:00:00 2001 From: Wonki Kim Date: Fri, 6 Dec 2019 08:30:51 +0000 Subject: [PATCH] collection_view: fix a potentional error assign signed int value on bigger unsigned variable can make information of the varaible lost. this patch fix the problem. Reviewed-by: Marcel Hollerbach Differential Revision: https://phab.enlightenment.org/D10723 --- src/lib/elementary/efl_ui_collection_view.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lib/elementary/efl_ui_collection_view.c b/src/lib/elementary/efl_ui_collection_view.c index 746c242..88dbb3c 100644 --- a/src/lib/elementary/efl_ui_collection_view.c +++ b/src/lib/elementary/efl_ui_collection_view.c @@ -2307,7 +2307,7 @@ _efl_ui_collection_view_focus_manager_efl_ui_focus_manager_request_move(Eo *obj, new_id = efl_ui_position_manager_entity_relative_item(cpd->manager, item_id, direction); - if (new_id == -1) + if (new_id < 0) { new_item = NULL; } @@ -2331,7 +2331,7 @@ _efl_ui_collection_view_focus_manager_efl_ui_focus_manager_request_move(Eo *obj, _assert_item_available(new_item, new_id, cpd); } #else - uint64_t search_index = new_id; + uint64_t search_index = (uint64_t)new_id; lookup = (void*) eina_rbtree_inline_lookup(cpd->cache, &search_index, sizeof (new_id), _cache_tree_lookup, NULL); -- 2.7.4