From ef75358080a28501eccc552a3fa8214ceb3f34dc Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Wed, 23 Jun 2021 16:24:41 -0400 Subject: [PATCH] [lld/mac] Delete incorrect FIXME """Bitcode symbols only exist before LTO runs, and only serve the purpose of resolving visibility so LTO can better optimize. Running LTO creates ObjFiles from BitcodeFiles, and those ObjFiles contain regular Defined symbols (with isec set and all) that will replace the bitcode symbols. So things should (hopefully) work as-is :)""" -- https://reviews.llvm.org/rGdbbc8d8333f29cf4ad6f4793da1adf71bbfdac69#inline-6081 --- lld/MachO/UnwindInfoSection.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/lld/MachO/UnwindInfoSection.cpp b/lld/MachO/UnwindInfoSection.cpp index e1e8d30..f82395b 100644 --- a/lld/MachO/UnwindInfoSection.cpp +++ b/lld/MachO/UnwindInfoSection.cpp @@ -297,8 +297,6 @@ static void addEntriesForFunctionsWithoutUnwindInfo( // Add explicit "has no unwind info" entries for all global and local symbols // without unwind info. auto markNoUnwindInfo = [&cuVector, &hasUnwindInfo](const Defined *d) { - // FIXME: The d->isec null check might be incorrect for symbols - // from LTO files. if (d->isLive() && d->isec && isCodeSection(d->isec)) { Ptr ptr = d->getVA(); if (!hasUnwindInfo.count(ptr)) -- 2.7.4