From ef58b0401a611a0a56541cf7cd0901d7f3fffd8f Mon Sep 17 00:00:00 2001 From: Eric Fiselier Date: Fri, 21 Apr 2017 03:09:40 +0000 Subject: [PATCH] update XFAIL comments with more details llvm-svn: 300944 --- libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.fail.cpp | 5 ++--- .../conversions/conversions.string/ctor_move.pass.cpp | 3 +-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.fail.cpp b/libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.fail.cpp index b5cee39..51a1f23 100644 --- a/libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.fail.cpp +++ b/libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.fail.cpp @@ -7,9 +7,8 @@ // //===----------------------------------------------------------------------===// -// There appears to be a bug in VerifyDiagnosticReporter on Windows that -// causes -verify to not see the emitted warnings even though they are -// actually getting omitted. +// This test fails because diagnose_if doesn't emit all of the diagnostics +// when -fdelayed-template-parsing is enabled, like it is on Windows. // XFAIL: LIBCXX-WINDOWS-FIXME // REQUIRES: verify-support, diagnose-if-support diff --git a/libcxx/test/libcxx/localization/locales/locale.convenience/conversions/conversions.string/ctor_move.pass.cpp b/libcxx/test/libcxx/localization/locales/locale.convenience/conversions/conversions.string/ctor_move.pass.cpp index 3983d80..18cc0ca 100644 --- a/libcxx/test/libcxx/localization/locales/locale.convenience/conversions/conversions.string/ctor_move.pass.cpp +++ b/libcxx/test/libcxx/localization/locales/locale.convenience/conversions/conversions.string/ctor_move.pass.cpp @@ -7,8 +7,7 @@ // //===----------------------------------------------------------------------===// -// This test fails because the `from_bytes` call seems to result in a call -// to 'abort()' +// 'do_bytes' throws a std::range_error unexpectedly // XFAIL: LIBCXX-WINDOWS-FIXME // UNSUPPORTED: c++98, c++03 -- 2.7.4