From ef1e583a2141f16261e3d1edb1ab4e9c55d902cb Mon Sep 17 00:00:00 2001 From: Sangchul Lee Date: Thu, 11 Jan 2024 16:19:49 +0900 Subject: [PATCH] test: Add missing lock [Version] 0.4.34 [Issue Type] Coverity defect (MISSING_LOCK) Change-Id: Id969572e1896b660b620216ecb376a43d4a891fd Signed-off-by: Sangchul Lee (cherry picked from commit 410af450e62993aa1ad54bd56b51f3449b9292b0) --- packaging/capi-media-webrtc.spec | 2 +- test/webrtc_test.c | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/packaging/capi-media-webrtc.spec b/packaging/capi-media-webrtc.spec index 679a7857..0f9b1bbb 100644 --- a/packaging/capi-media-webrtc.spec +++ b/packaging/capi-media-webrtc.spec @@ -1,6 +1,6 @@ Name: capi-media-webrtc Summary: A WebRTC library in Tizen Native API -Version: 0.4.33 +Version: 0.4.34 Release: 0 Group: Multimedia/API License: Apache-2.0 diff --git a/test/webrtc_test.c b/test/webrtc_test.c index b0ce35a2..7531fec5 100644 --- a/test/webrtc_test.c +++ b/test/webrtc_test.c @@ -2221,9 +2221,9 @@ static void __media_packet_source_buffer_state_changed_cb(unsigned int source_id } g_mutex_lock(&conn->packet_sources[i].mutex); conn->packet_sources[i].is_overflowed = (state == WEBRTC_MEDIA_PACKET_SOURCE_BUFFER_STATE_OVERFLOW); - g_mutex_unlock(&conn->packet_sources[i].mutex); if (!conn->packet_sources[i].is_overflowed) g_cond_signal(&conn->packet_sources[i].cond); + g_mutex_unlock(&conn->packet_sources[i].mutex); } static void _webrtc_media_packet_source_set_buffer_state_changed_cb(int index, unsigned int source_id) @@ -3007,8 +3007,10 @@ static void _stop_pushing_packet(int index, int source_id) RET_IF(!g_ad.conns[index].packet_sources[i].src_pipeline, "already stopped for pushing packet"); + g_mutex_lock(&g_ad.conns[index].packet_sources[i].mutex); if (g_ad.conns[index].packet_sources[i].is_overflowed) g_cond_signal(&g_ad.conns[index].packet_sources[i].cond); + g_mutex_unlock(&g_ad.conns[index].packet_sources[i].mutex); g_ad.conns[index].packet_sources[i].is_stop_requested = true; -- 2.34.1