From ee7e03e19e7447985d4710dd93d94bdecc665989 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Wed, 28 Oct 2020 23:58:31 -0700 Subject: [PATCH] [Reassociate][test] Delete improper -NOT patterns to work with -enable-new-pm=1 The two tests rely on LegacyInlinerBase::doFinalization to remove Function::isDefTriviallyDead() functions. The new PM does not have the behavior. The -NEXT patterns checking the emptiness are actually sufficient. Note, reassociate-deadinst.ll has become stale - it no longer catches the problem r285380 intended. Unfortunately it is difficult to craft a new test because it is actually pretty difficult to break it with `MadeChange = true;` all over the file. --- llvm/test/Transforms/Reassociate/erase_inst_made_change.ll | 1 - llvm/test/Transforms/Reassociate/reassociate-deadinst.ll | 1 - 2 files changed, 2 deletions(-) diff --git a/llvm/test/Transforms/Reassociate/erase_inst_made_change.ll b/llvm/test/Transforms/Reassociate/erase_inst_made_change.ll index febb9447..0bb926f 100644 --- a/llvm/test/Transforms/Reassociate/erase_inst_made_change.ll +++ b/llvm/test/Transforms/Reassociate/erase_inst_made_change.ll @@ -21,7 +21,6 @@ entry: } define internal void @bar() noinline nounwind readnone { -; CHECK-NOT: bar entry: ret void } diff --git a/llvm/test/Transforms/Reassociate/reassociate-deadinst.ll b/llvm/test/Transforms/Reassociate/reassociate-deadinst.ll index 9266fce..5384a65 100644 --- a/llvm/test/Transforms/Reassociate/reassociate-deadinst.ll +++ b/llvm/test/Transforms/Reassociate/reassociate-deadinst.ll @@ -1,6 +1,5 @@ ; RUN: opt < %s -inline -function-attrs -reassociate -S | FileCheck %s -; CHECK-NOT: func1 ; CHECK-LABEL: main ; CHECK-NEXT: ret void -- 2.7.4