From ee31f61c8e6fb52b9a0f2f6e995ab43900797d55 Mon Sep 17 00:00:00 2001 From: Brendan Gregg Date: Wed, 10 Feb 2016 22:32:03 -0800 Subject: [PATCH] fix for spaces in filenames, #361 --- tools/filelife.py | 2 +- tools/opensnoop.py | 4 ++-- tools/statsnoop.py | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/filelife.py b/tools/filelife.py index 9786fd7..075be08 100755 --- a/tools/filelife.py +++ b/tools/filelife.py @@ -97,7 +97,7 @@ start_ts = 0 # format output while 1: (task, pid, cpu, flags, ts, msg) = b.trace_fields() - (delta, filename) = msg.split(" ") + (delta, filename) = msg.split(" ", 1) # print columns print("%-8s %-6d %-16s %-7.2f %s" % (strftime("%H:%M:%S"), pid, task, diff --git a/tools/opensnoop.py b/tools/opensnoop.py index 83a9a7b..5df3b41 100755 --- a/tools/opensnoop.py +++ b/tools/opensnoop.py @@ -63,7 +63,7 @@ int kretprobe__sys_open(struct pt_regs *ctx) return 0; } - bpf_trace_printk("%s %d\\n", *filenamep, ret); + bpf_trace_printk("%d %s\\n", ret, *filenamep); args_filename.delete(&pid); return 0; @@ -90,7 +90,7 @@ start_ts = 0 # format output while 1: (task, pid, cpu, flags, ts, msg) = b.trace_fields() - (filename, ret_s) = msg.split(" ") + (ret_s, filename) = msg.split(" ", 1) ret = int(ret_s) if (args.failed and (ret >= 0)): diff --git a/tools/statsnoop.py b/tools/statsnoop.py index fd6b160..ad54ac7 100755 --- a/tools/statsnoop.py +++ b/tools/statsnoop.py @@ -63,7 +63,7 @@ int trace_return(struct pt_regs *ctx) return 0; } - bpf_trace_printk("%s %d\\n", *filenamep, ret); + bpf_trace_printk("%d %s\\n", ret, *filenamep); args_filename.delete(&pid); return 0; @@ -96,7 +96,7 @@ start_ts = 0 # format output while 1: (task, pid, cpu, flags, ts, msg) = b.trace_fields() - (filename, ret_s) = msg.split(" ") + (ret_s, filename) = msg.split(" ", 1) ret = int(ret_s) if (args.failed and (ret >= 0)): -- 2.7.4