From ee1b334a03d383b80266ba966b7a8c84eb9d6e10 Mon Sep 17 00:00:00 2001 From: Leandro Dorileo Date: Thu, 15 Jan 2015 11:24:57 -0200 Subject: [PATCH] test: fix buffer overrun issue Make sure we don't run o buffer overrun by setting the status if we don't know the passed value: Pointed out by coverity tests: https://bugs.tizen.org/jira/browse/TC-2097 --- src/bin/test.c | 4 ++++ src/lib/lightmediascanner.h | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/bin/test.c b/src/bin/test.c index 010138c..c8a1557 100644 --- a/src/bin/test.c +++ b/src/bin/test.c @@ -276,6 +276,7 @@ progress(lms_t *lms, const char *path, int path_len, lms_progress_status_t statu "ERROR_PARSE", "ERROR_COMM", "SKIPPED", + "UNKNOWN", }; const char *cstart = "", *cend = "", *name = data; @@ -296,6 +297,9 @@ progress(lms_t *lms, const char *path, int path_len, lms_progress_status_t statu case LMS_PROGRESS_STATUS_ERROR_COMM: cstart = "\033[31m"; break; + default: + status = LMS_PROGRESS_STATUS_UNKNOWN; + break; } } diff --git a/src/lib/lightmediascanner.h b/src/lib/lightmediascanner.h index ec1601a..d159bc8 100644 --- a/src/lib/lightmediascanner.h +++ b/src/lib/lightmediascanner.h @@ -171,7 +171,8 @@ extern "C" { LMS_PROGRESS_STATUS_KILLED, LMS_PROGRESS_STATUS_ERROR_PARSE, LMS_PROGRESS_STATUS_ERROR_COMM, - LMS_PROGRESS_STATUS_SKIPPED + LMS_PROGRESS_STATUS_SKIPPED, + LMS_PROGRESS_STATUS_UNKNOWN, } lms_progress_status_t; typedef void (*lms_free_callback_t)(void *data); -- 2.7.4