From edcc2a280df26a10a84c283d7cdab4b48864e5b8 Mon Sep 17 00:00:00 2001 From: Seung-Woo Kim Date: Thu, 25 May 2023 20:00:30 +0900 Subject: [PATCH] phy/realtek: Fix null deference for g_phydev Amlogic wol support adds g_phydev global variable and it can be accessed before setting. Fix not to access null g_phydev and instead, setting the variable with phydev. Change-Id: I3b6860431c9d0872b1d421d124522fef51cb4f65 Fixes: 254065327d58 ("phy/realtek: fixup suspend failed issue") Signed-off-by: Seung-Woo Kim --- drivers/net/phy/realtek.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c index 2b18300d1316..606d89567995 100644 --- a/drivers/net/phy/realtek.c +++ b/drivers/net/phy/realtek.c @@ -270,6 +270,9 @@ int rtl8211f_suspend(struct phy_device *phydev) } else { int value; + if (!g_phydev) + g_phydev = phydev; + /*pin 31 pull high*/ phy_write(g_phydev, RTL8211F_PAGE_SELECT, 0xd40); value = phy_read(g_phydev, 0x16); -- 2.34.1