From ed67fd868e3ed61ede0fd8e4af21c245e7abd1bd Mon Sep 17 00:00:00 2001 From: jiangyuwei Date: Fri, 3 Mar 2023 14:44:55 +0800 Subject: [PATCH] [M108 Migration] Fix svace warning Release the value from app_control_get_extra_data. Reference: - https://review.tizen.org/gerrit/#/c/267099/ - https://review.tizen.org/gerrit/#/c/265555/ Change-Id: I6697cccaea5c10272440b583aed8432f76b1fc6d Signed-off-by: jiangyuwei --- tizen_src/ewk/efl_integration/public/ewk_context.cc | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/tizen_src/ewk/efl_integration/public/ewk_context.cc b/tizen_src/ewk/efl_integration/public/ewk_context.cc index 3df8af5..4e0e4a1 100644 --- a/tizen_src/ewk/efl_integration/public/ewk_context.cc +++ b/tizen_src/ewk/efl_integration/public/ewk_context.cc @@ -1014,6 +1014,8 @@ Eina_Bool ewk_context_app_control_set(const Ewk_Context* context, void* app_cont ¬ification_id); if (ret != APP_CONTROL_ERROR_NONE) { LOG(ERROR) << "app_control_get_extra_data is failed with err " << ret; + if (notification_id) + free(notification_id); return EINA_FALSE; } @@ -1023,11 +1025,13 @@ Eina_Bool ewk_context_app_control_set(const Ewk_Context* context, void* app_cont char* notification_origin = nullptr; app_control_get_extra_data(control, "notification_origin", ¬ification_origin); - cbce->GetNotificationController()-> - PersistentNotificationClicked(context->browser_context(), - notification_id, - notification_origin); + if (notification_origin) { + cbce->GetNotificationController()->PersistentNotificationClicked( + context->browser_context(), notification_id, notification_origin); + free(notification_origin); + } } + free(notification_id); } return EINA_TRUE; #else -- 2.7.4