From ed626321f7b39b607f1f542eb3a0b7d5d468c271 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Tim-Philipp=20M=C3=BCller?= Date: Wed, 27 Jan 2010 23:46:32 +0000 Subject: [PATCH] dataurisrc: don't post error message when setting the URI failed There's a gboolean return for that, and the messages don't really add anything useful. --- plugins/elements/gstdataurisrc.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/plugins/elements/gstdataurisrc.c b/plugins/elements/gstdataurisrc.c index da91390..04deed9 100644 --- a/plugins/elements/gstdataurisrc.c +++ b/plugins/elements/gstdataurisrc.c @@ -410,32 +410,32 @@ gst_data_uri_src_set_uri (GstURIHandler * handler, const gchar * uri) gst_caps_unref (caps); ret = TRUE; - GST_OBJECT_UNLOCK (src); + out: + + GST_OBJECT_UNLOCK (src); + g_free (mimetype); g_free (charset); - return ret; invalid_uri: { - GST_OBJECT_UNLOCK (src); - GST_ELEMENT_ERROR (src, STREAM, FORMAT, (NULL), (NULL)); + GST_WARNING_OBJECT (src, "invalid URI '%s'", uri); + goto out; } - goto out; wrong_state: { - GST_OBJECT_UNLOCK (src); - GST_ELEMENT_ERROR (src, CORE, FAILED, (NULL), (NULL)); + GST_WARNING_OBJECT (src, "Can't set URI in %s state", + gst_element_state_get_name (GST_STATE (src))); + goto out; } - goto out; invalid_uri_encoded_data: { - GST_OBJECT_UNLOCK (src); - GST_ELEMENT_ERROR (src, STREAM, FORMAT, (NULL), (NULL)); + GST_WARNING_OBJECT (src, "Failed to parse data encoded in URI '%s'", uri); + goto out; } - goto out; } static gboolean -- 2.7.4