From ed29e29a3c2148bbe8b5a0fd915f012b2dad604f Mon Sep 17 00:00:00 2001 From: James Turner Date: Wed, 20 Jun 2012 14:55:40 +0200 Subject: [PATCH] Fix QWidgetWindow sending duplicate drag-drop events Unlike the other event handlers in QWidgetWindow, the drag-drop events are not followed by an early return. This causes all drag-drop events to also be sent to the root widget of the window, which is a bug. For example in the fridgemagnets example, where the target widget and root widget are the same, the drop event is received twice. Change-Id: I99e56ad8c48b3d31b0bd7c815cea8490edbf0af4 Reviewed-by: Friedemann Kleint --- src/widgets/kernel/qwidgetwindow_qpa.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/widgets/kernel/qwidgetwindow_qpa.cpp b/src/widgets/kernel/qwidgetwindow_qpa.cpp index 7ae0a5b..f8a5178 100644 --- a/src/widgets/kernel/qwidgetwindow_qpa.cpp +++ b/src/widgets/kernel/qwidgetwindow_qpa.cpp @@ -162,7 +162,7 @@ bool QWidgetWindow::event(QEvent *event) case QEvent::DragMove: case QEvent::Drop: handleDragEvent(event); - break; + return true; #endif case QEvent::Expose: -- 2.7.4