From ecdc7507ab3080b252539c1ab57e80c4c34cf65f Mon Sep 17 00:00:00 2001 From: Alexander Kornienko Date: Thu, 6 Dec 2012 17:49:17 +0000 Subject: [PATCH] Clang-format: detect unbalanced braces. Reviewers: klimek, djasper Reviewed By: klimek CC: cfe-commits, silvas Differential Revision: http://llvm-reviews.chandlerc.com/D176 llvm-svn: 169518 --- clang/lib/Format/UnwrappedLineParser.cpp | 5 +++-- clang/unittests/Format/FormatTest.cpp | 1 + 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/clang/lib/Format/UnwrappedLineParser.cpp b/clang/lib/Format/UnwrappedLineParser.cpp index 99e5832..425e15b 100644 --- a/clang/lib/Format/UnwrappedLineParser.cpp +++ b/clang/lib/Format/UnwrappedLineParser.cpp @@ -52,8 +52,8 @@ bool UnwrappedLineParser::parseLevel() { addUnwrappedLine(); break; case tok::r_brace: - // FIXME: We need a test when it has to be "return Error;" - return false; + // Stray '}' is an error. + return true; default: parseStatement(); break; @@ -63,6 +63,7 @@ bool UnwrappedLineParser::parseLevel() { } bool UnwrappedLineParser::parseBlock() { + assert(FormatTok.Tok.is(tok::l_brace) && "'{' expected"); nextToken(); // FIXME: Remove this hack to handle namespaces. diff --git a/clang/unittests/Format/FormatTest.cpp b/clang/unittests/Format/FormatTest.cpp index a2a37cf..c385e35 100644 --- a/clang/unittests/Format/FormatTest.cpp +++ b/clang/unittests/Format/FormatTest.cpp @@ -428,6 +428,7 @@ TEST_F(FormatTest, IncorrectCodeErrorDetection) { EXPECT_EQ("{\n{\n}\n", format("{\n{\n}\n")); EXPECT_EQ("{\n {\n}\n", format("{\n {\n}\n")); EXPECT_EQ("{\n {\n }\n", format("{\n {\n }\n")); + EXPECT_EQ("{\n {\n }\n }\n}\n", format("{\n {\n }\n }\n}\n")); FormatStyle Style = getLLVMStyle(); Style.ColumnLimit = 10; -- 2.7.4