From ec9a9ac103889c624725e9ec64582317829d15d2 Mon Sep 17 00:00:00 2001 From: "jkummerow@chromium.org" Date: Mon, 18 Nov 2013 14:32:30 +0000 Subject: [PATCH] Fix broken pipe caused by commands in toolchain.gypi. I sometimes observe broken pipe errors when I run gyp, which causes the gyp process to fail. This seems to happen if gyp is executed under heavy I/O pressure. This change removes the pipes by replacing "echo |" with "< /dev/null". Technically these are not the same, because "echo |" prints a newline while "< /dev/null" doesn't, but this difference is not significant in the context of the commands in toolchain.gypi. BUG= R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/73623002 Patch from Yuta Kitamura . git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17836 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- build/toolchain.gypi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/build/toolchain.gypi b/build/toolchain.gypi index de41fe0..99f357a 100644 --- a/build/toolchain.gypi +++ b/build/toolchain.gypi @@ -376,7 +376,7 @@ 'target_conditions': [ ['_toolset=="host"', { 'variables': { - 'm32flag': ' /dev/null 2>&1) && echo "-m32" || true)', + 'm32flag': ' /dev/null 2>&1 < /dev/null) && echo "-m32" || true)', }, 'cflags': [ '<(m32flag)' ], 'ldflags': [ '<(m32flag)' ], @@ -386,7 +386,7 @@ }], ['_toolset=="target"', { 'variables': { - 'm32flag': ' /dev/null 2>&1) && echo "-m32" || true)', + 'm32flag': ' /dev/null 2>&1 < /dev/null) && echo "-m32" || true)', 'clang%': 0, }, 'conditions': [ @@ -408,14 +408,14 @@ 'target_conditions': [ ['_toolset=="host"', { 'variables': { - 'm64flag': ' /dev/null 2>&1) && echo "-m64" || true)', + 'm64flag': ' /dev/null 2>&1 < /dev/null) && echo "-m64" || true)', }, 'cflags': [ '<(m64flag)' ], 'ldflags': [ '<(m64flag)' ], }], ['_toolset=="target"', { 'variables': { - 'm64flag': ' /dev/null 2>&1) && echo "-m64" || true)', + 'm64flag': ' /dev/null 2>&1 < /dev/null) && echo "-m64" || true)', }, 'cflags': [ '<(m64flag)' ], 'ldflags': [ '<(m64flag)' ], -- 2.7.4