From ec37f1e1e18ee9667788934e6bdbd8aff3140f2f Mon Sep 17 00:00:00 2001
From: =?utf8?q?=D0=9F=D0=B0=D0=B2=D0=B5=D0=BB=20=D0=A4=D0=B0=D1=82=D1=82?=
=?utf8?q?=D0=B0=D1=85=D0=BE=D0=B2/AI=20Tools=20Lab=20/SRR/Assistant=20Eng?=
=?utf8?q?ineer/=EC=82=BC=EC=84=B1=EC=A0=84=EC=9E=90?=
Date: Tue, 20 Nov 2018 21:10:31 +0300
Subject: [PATCH] [nnc] fix static analysis warning and add missed break
(#2287)
- Add assert, which protects us from passing a null pointer to a function.
- Add break statement into switch in tflite_importer.
Signed-off-by: Pavel
---
contrib/nnc/passes/tflite_frontend/tflite_importer.cpp | 2 ++
1 file changed, 2 insertions(+)
diff --git a/contrib/nnc/passes/tflite_frontend/tflite_importer.cpp b/contrib/nnc/passes/tflite_frontend/tflite_importer.cpp
index 318658a..d96fe5a 100644
--- a/contrib/nnc/passes/tflite_frontend/tflite_importer.cpp
+++ b/contrib/nnc/passes/tflite_frontend/tflite_importer.cpp
@@ -188,6 +188,7 @@ void TfliteImporter::walkOperator(const Operator* op) {
break;
case BuiltinOperator_SQUEEZE:
outputs = _opCreator->createSqueeze(inputs, params, op->builtin_options_as());
+ break;
case BuiltinOperator_ADD:
outputs = _opCreator->createAdd(inputs, params, op->builtin_options_as());
break;
@@ -264,6 +265,7 @@ std::vector> TfliteImporter::createOpParams(const Oper
std::shared_ptr TfliteImporter::createTensor(const Tensor* t, const Buffer* b) {
// Create TensorVariant by copying the tensor buffer contents.
// Another option is to copy the data in a TensorVariant constructor.
+ assert(b->data() != nullptr);
std::shared_ptr tensor_buffer_copy(new char[b->data()->size()],
[](char* d) { delete[] d; });
std::copy(b->data()->begin(), b->data()->end(), tensor_buffer_copy.get());
--
2.7.4