From ec235dd3556d9879b0ec58ebd6009904d0ef0d24 Mon Sep 17 00:00:00 2001 From: Lang Hames Date: Tue, 30 Mar 2021 22:56:41 -0700 Subject: [PATCH] [JITLink] Delete copy and move constructors for jitlink::Section. Sections are not movable or copyable. --- llvm/include/llvm/ExecutionEngine/JITLink/JITLink.h | 6 ++++++ llvm/unittests/ExecutionEngine/JITLink/LinkGraphTests.cpp | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/llvm/include/llvm/ExecutionEngine/JITLink/JITLink.h b/llvm/include/llvm/ExecutionEngine/JITLink/JITLink.h index 646cc4c..f25bad6 100644 --- a/llvm/include/llvm/ExecutionEngine/JITLink/JITLink.h +++ b/llvm/include/llvm/ExecutionEngine/JITLink/JITLink.h @@ -590,6 +590,12 @@ public: ~Section(); + // Sections are not movable or copyable. + Section(const Section &) = delete; + Section &operator=(const Section &) = delete; + Section(Section &&) = delete; + Section &operator=(Section &&) = delete; + /// Returns the name of this section. StringRef getName() const { return Name; } diff --git a/llvm/unittests/ExecutionEngine/JITLink/LinkGraphTests.cpp b/llvm/unittests/ExecutionEngine/JITLink/LinkGraphTests.cpp index a60a04e..4685193 100644 --- a/llvm/unittests/ExecutionEngine/JITLink/LinkGraphTests.cpp +++ b/llvm/unittests/ExecutionEngine/JITLink/LinkGraphTests.cpp @@ -42,7 +42,7 @@ TEST(LinkGraphTest, AddressAccess) { LinkGraph G("foo", Triple("x86_64-apple-darwin"), 8, support::little, getGenericEdgeKindName); - auto Sec1 = G.createSection("__data.1", RWFlags); + auto &Sec1 = G.createSection("__data.1", RWFlags); auto &B1 = G.createContentBlock(Sec1, BlockContent, 0x1000, 8, 0); auto &S1 = G.addDefinedSymbol(B1, 4, "S1", 4, Linkage::Strong, Scope::Default, false, false); -- 2.7.4