From ebcc6c3a7b5021bab3cc30e9b7d4c340153a0c32 Mon Sep 17 00:00:00 2001 From: Yao Qi Date: Thu, 14 Aug 2014 15:24:58 +0800 Subject: [PATCH] Skip tfile.exp if unable to generate trace file I added proc generate_tracefile in this patch https://sourceware.org/ml/gdb-patches/2014-03/msg00591.html but tfile.exp isn't skipped as changelog entry said: * gdb.trace/tfile.exp: Skip the test if generate_tracefile return 0. it is a mistake I made at the last minute. Patch below fixed it. gdb/testsuite: 2014-08-15 Yao Qi * gdb.trace/tfile.exp: Return -1 if generate_tracefile returns false. --- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/gdb.trace/tfile.exp | 1 + 2 files changed, 6 insertions(+) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 1be9268..18930a0 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,5 +1,10 @@ 2014-08-15 Yao Qi + * gdb.trace/tfile.exp: Return -1 if generate_tracefile returns + false. + +2014-08-15 Yao Qi + * gdb.cp/casts.exp: Set print symbol off. * gdb.cp/class2.exp: Likewise. * gdb.cp/overload.exp: Likewise. diff --git a/gdb/testsuite/gdb.trace/tfile.exp b/gdb/testsuite/gdb.trace/tfile.exp index 54648b8..c8fd01c 100644 --- a/gdb/testsuite/gdb.trace/tfile.exp +++ b/gdb/testsuite/gdb.trace/tfile.exp @@ -52,6 +52,7 @@ remote_file target delete $tfile_error if { ![generate_tracefile $binfile] } { unsupported "Unable to generate trace file" + return -1 } if {!$purely_local} { -- 2.7.4