From ebc77ce3a4c70730b4e38d68f88693eadbdc8712 Mon Sep 17 00:00:00 2001 From: Tom de Vries Date: Wed, 7 Oct 2020 07:22:43 +0200 Subject: [PATCH] [tree-ssa-loop-ch] Add missing NULL test for dump_file If we change gimple_can_duplicate_bb_p to return false instead of true, we run into a segfault in ch_base::copy_headers due to using dump_file while it's NULL: ... if (!gimple_duplicate_sese_region (entry, exit, bbs, n_bbs, copied_bbs, true)) { fprintf (dump_file, "Duplication failed.\n"); continue; } ... Fix this by adding the missing dump_file != NULL test. Tested by rebuilding lto1 and rerunning the failing test-case. gcc/ChangeLog: 2020-10-07 Tom de Vries * tree-ssa-loop-ch.c (ch_base::copy_headers): Add missing NULL test for dump_file. --- gcc/tree-ssa-loop-ch.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gcc/tree-ssa-loop-ch.c b/gcc/tree-ssa-loop-ch.c index b86acf7..1f3d932 100644 --- a/gcc/tree-ssa-loop-ch.c +++ b/gcc/tree-ssa-loop-ch.c @@ -425,7 +425,8 @@ ch_base::copy_headers (function *fun) if (!gimple_duplicate_sese_region (entry, exit, bbs, n_bbs, copied_bbs, true)) { - fprintf (dump_file, "Duplication failed.\n"); + if (dump_file && (dump_flags & TDF_DETAILS)) + fprintf (dump_file, "Duplication failed.\n"); continue; } copied.safe_push (std::make_pair (entry, loop)); -- 2.7.4