From eb8056f2857f872673aea1fc0b0f4b7298286c9e Mon Sep 17 00:00:00 2001 From: "machenbach@chromium.org" Date: Mon, 13 Jan 2014 08:15:56 +0000 Subject: [PATCH] [Sheriff] Revert "Turn on allocation site pretenuring." This reverts commit r18547 for breaking the GC stress builders. BUG= TBR=hpayer@chromium.org Review URL: https://codereview.chromium.org/136323002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18549 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/flag-definitions.h | 2 +- test/cctest/test-heap.cc | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/flag-definitions.h b/src/flag-definitions.h index bbad227..93adb62 100644 --- a/src/flag-definitions.h +++ b/src/flag-definitions.h @@ -220,7 +220,7 @@ DEFINE_bool(pretenuring, true, "allocate objects in old space") // TODO(hpayer): We will remove this flag as soon as we have pretenuring // support for specific allocation sites. DEFINE_bool(pretenuring_call_new, false, "pretenure call new") -DEFINE_bool(allocation_site_pretenuring, true, +DEFINE_bool(allocation_site_pretenuring, false, "pretenure with allocation sites") DEFINE_bool(trace_pretenuring, false, "trace pretenuring decisions of HAllocate instructions") diff --git a/test/cctest/test-heap.cc b/test/cctest/test-heap.cc index da57efa..d5fae58 100644 --- a/test/cctest/test-heap.cc +++ b/test/cctest/test-heap.cc @@ -2206,10 +2206,10 @@ TEST(OptimizedPretenuringAllocationFolding) { " this.e = 1.3;" " this.f = [{}];" "}" - "var number_elements = 30000;" + "var number_elements = 20000;" "var elements = new Array();" "function f() {" - " for (var i = 0; i < number_elements-1; i++) {" + " for (var i = 0; i < 20000-1; i++) {" " elements[i] = new DataObject();" " }" " return new DataObject()" @@ -2240,7 +2240,7 @@ TEST(OptimizedPretenuringAllocationFoldingBlocks) { CcTest::heap()->SetNewSpaceHighPromotionModeActive(true); v8::Local res = CompileRun( - "var number_elements = 20000;" + "var number_elements = 3000;" "var elements = new Array(number_elements);" "function DataObject() {" " this.a = [{}];" @@ -2345,7 +2345,7 @@ TEST(OptimizedPretenuringDoubleArrayProperties) { v8::HandleScope scope(CcTest::isolate()); v8::Local res = CompileRun( - "var number_elements = 30000;" + "var number_elements = 20000;" "var elements = new Array(number_elements);" "function f() {" " for (var i = 0; i < number_elements; i++) {" -- 2.7.4