From eb0988917670e0a3a5dfe7555d97481aa863b6c5 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Sebastian=20Dr=C3=B6ge?= Date: Tue, 29 Dec 2015 18:14:54 +0200 Subject: [PATCH] audioconvert: Pass pointer arrays instead of singleton pointers to gst_audio_converter_samples() In this specific case it wouldn't cause problems as we only ever access the first array element, but let's make explicit what is happening here. CID 1346530 and 1346529 --- gst/audioconvert/gstaudioconvert.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/gst/audioconvert/gstaudioconvert.c b/gst/audioconvert/gstaudioconvert.c index fc002d9..e5e8bbb 100644 --- a/gst/audioconvert/gstaudioconvert.c +++ b/gst/audioconvert/gstaudioconvert.c @@ -737,9 +737,11 @@ gst_audio_convert_transform (GstBaseTransform * base, GstBuffer * inbuf, flags |= GST_AUDIO_CONVERTER_FLAG_SOURCE_WRITABLE; if (!GST_BUFFER_FLAG_IS_SET (inbuf, GST_BUFFER_FLAG_GAP)) { + gpointer in[1] = { srcmap.data }; + gpointer out[1] = { dstmap.data }; + if (!gst_audio_converter_samples (this->convert, flags, - (gpointer *) & srcmap.data, samples, (gpointer *) & dstmap.data, - samples, &consumed, &produced)) + in, samples, out, samples, &consumed, &produced)) goto convert_error; } else { /* Create silence buffer */ -- 2.7.4