From eafb8c29d37946e263d07067a173861087bd17a9 Mon Sep 17 00:00:00 2001 From: Peter Varga Date: Thu, 18 Oct 2012 17:16:40 +0200 Subject: [PATCH] Re-enable tst_QJSEngine::stringObjects test Corresponding bug has been fixed in QtJSBackend thus re-enable test and remove expected failures. Change-Id: I72d6ce31a1c932db29dad0758e0c2654543a5b1f Reviewed-by: Simon Hausmann --- tests/auto/qml/qjsengine/tst_qjsengine.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/tests/auto/qml/qjsengine/tst_qjsengine.cpp b/tests/auto/qml/qjsengine/tst_qjsengine.cpp index 7892290..87d2673 100644 --- a/tests/auto/qml/qjsengine/tst_qjsengine.cpp +++ b/tests/auto/qml/qjsengine/tst_qjsengine.cpp @@ -1955,8 +1955,6 @@ void tst_QJSEngine::stringObjects() { // See ECMA-262 Section 15.5, "String Objects". - QSKIP("This test is temporarily skipped until fix is not landed: https://codereview.qt-project.org/#change,37284"); - QJSEngine eng; QString str("ciao"); // in C++ @@ -1967,7 +1965,6 @@ void tst_QJSEngine::stringObjects() QString pname = QString::number(i); QVERIFY(obj.property(pname).isString()); QCOMPARE(obj.property(pname).toString(), QString(str.at(i))); - QEXPECT_FAIL("", "FIXME: This is V8 issue 862. ECMA script standard 15.5.5.2 compliance.", Continue); QVERIFY(!obj.deleteProperty(pname)); obj.setProperty(pname, 123); QVERIFY(obj.property(pname).isString()); @@ -2006,7 +2003,6 @@ void tst_QJSEngine::stringObjects() QJSValue ret5 = eng.evaluate("delete s[0]"); QVERIFY(ret5.isBool()); - QEXPECT_FAIL("", "FIXME: This is V8 bug, please report it! ECMA script standard 15.5.5.2", Abort); QVERIFY(!ret5.toBool()); QJSValue ret6 = eng.evaluate("delete s[-1]"); -- 2.7.4