From eaa2250bcfd78ea84746e25ee467be0445e7daf8 Mon Sep 17 00:00:00 2001 From: Kyle Date: Mon, 27 Jan 2014 14:27:53 -0600 Subject: [PATCH] get_build_triggerurl logic fix job.get_build_triggerurl had invalid logic for determining what build url to be using. Parameterized builds can only be started via the rest API with the buildWithParameters endpoint even if you don't pass any parameters in. --- jenkinsapi/job.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/jenkinsapi/job.py b/jenkinsapi/job.py index 49f4972..1faad22 100644 --- a/jenkinsapi/job.py +++ b/jenkinsapi/job.py @@ -127,9 +127,9 @@ class Job(JenkinsBase, MutableJenkinsThing): return self._element_tree def get_build_triggerurl(self, build_params=None, files=None): - if build_params or files: - return "%s/buildWithParameters" % self.baseurl - return "%s/build" % self.baseurl + if len(self.get_params_list()) == 0: + return "%s/build" % self.baseurl + return "%s/buildWithParameters" % self.baseurl @staticmethod def _mk_json_from_build_parameters(build_params): -- 2.7.4