From e9d3f708220a4595885937f2607c26fac7b479da Mon Sep 17 00:00:00 2001 From: Johannes Doerfert Date: Sun, 13 Oct 2019 05:07:00 +0000 Subject: [PATCH] [Attributor] Remove unused verification flag We use the verify max iteration now which is more reliable. llvm-svn: 374701 --- llvm/lib/Transforms/IPO/Attributor.cpp | 24 ------------------------ 1 file changed, 24 deletions(-) diff --git a/llvm/lib/Transforms/IPO/Attributor.cpp b/llvm/lib/Transforms/IPO/Attributor.cpp index 0437803..23e48e3 100644 --- a/llvm/lib/Transforms/IPO/Attributor.cpp +++ b/llvm/lib/Transforms/IPO/Attributor.cpp @@ -125,12 +125,6 @@ static cl::opt ManifestInternal( cl::desc("Manifest Attributor internal string attributes."), cl::init(false)); -static cl::opt VerifyAttributor( - "attributor-verify", cl::Hidden, - cl::desc("Verify the Attributor deduction and " - "manifestation of attributes -- may issue false-positive errors"), - cl::init(false)); - static cl::opt DepRecInterval( "attributor-dependence-recompute-interval", cl::Hidden, cl::desc("Number of iterations until dependences are recomputed."), @@ -4501,24 +4495,6 @@ ChangeStatus Attributor::run(Module &M) { << " arguments while " << NumAtFixpoint << " were in a valid fixpoint state\n"); - // If verification is requested, we finished this run at a fixpoint, and the - // IR was changed, we re-run the whole fixpoint analysis, starting at - // re-initialization of the arguments. This re-run should not result in an IR - // change. Though, the (virtual) state of attributes at the end of the re-run - // might be more optimistic than the known state or the IR state if the better - // state cannot be manifested. - if (VerifyAttributor && FinishedAtFixpoint && - ManifestChange == ChangeStatus::CHANGED) { - VerifyAttributor = false; - ChangeStatus VerifyStatus = run(M); - if (VerifyStatus != ChangeStatus::UNCHANGED) - llvm_unreachable( - "Attributor verification failed, re-run did result in an IR change " - "even after a fixpoint was reached in the original run. (False " - "positives possible!)"); - VerifyAttributor = true; - } - NumAttributesManifested += NumManifested; NumAttributesValidFixpoint += NumAtFixpoint; -- 2.7.4