From e9c8de04da2cfad52ccc09219a808c204870d215 Mon Sep 17 00:00:00 2001 From: "marja@chromium.org" Date: Mon, 13 Jan 2014 11:15:06 +0000 Subject: [PATCH] Fix r18556; tests were missing handlescopes. BUG= R=ulan@chromium.org Review URL: https://codereview.chromium.org/133763005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18560 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- test/cctest/test-api.cc | 4 ++++ test/cctest/test-parsing.cc | 1 + 2 files changed, 5 insertions(+) diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc index fe6ec1f..839ddd9 100644 --- a/test/cctest/test-api.cc +++ b/test/cctest/test-api.cc @@ -14785,6 +14785,7 @@ TEST(PreCompile) { // a workaround for now to make this test not fail. v8::V8::Initialize(); v8::Isolate* isolate = CcTest::isolate(); + HandleScope handle_scope(isolate); const char* script = "function foo(a) { return a+1; }"; v8::ScriptData* sd = v8::ScriptData::PreCompile(v8::String::NewFromUtf8( isolate, script, v8::String::kNormalString, i::StrLength(script))); @@ -14798,6 +14799,7 @@ TEST(PreCompile) { TEST(PreCompileWithError) { v8::V8::Initialize(); v8::Isolate* isolate = CcTest::isolate(); + HandleScope handle_scope(isolate); const char* script = "function foo(a) { return 1 * * 2; }"; v8::ScriptData* sd = v8::ScriptData::PreCompile(v8::String::NewFromUtf8( isolate, script, v8::String::kNormalString, i::StrLength(script))); @@ -14809,6 +14811,7 @@ TEST(PreCompileWithError) { TEST(Regress31661) { v8::V8::Initialize(); v8::Isolate* isolate = CcTest::isolate(); + HandleScope handle_scope(isolate); const char* script = " The Definintive Guide"; v8::ScriptData* sd = v8::ScriptData::PreCompile(v8::String::NewFromUtf8( isolate, script, v8::String::kNormalString, i::StrLength(script))); @@ -14821,6 +14824,7 @@ TEST(Regress31661) { TEST(PreCompileSerialization) { v8::V8::Initialize(); v8::Isolate* isolate = CcTest::isolate(); + HandleScope handle_scope(isolate); const char* script = "function foo(a) { return a+1; }"; v8::ScriptData* sd = v8::ScriptData::PreCompile(v8::String::NewFromUtf8( isolate, script, v8::String::kNormalString, i::StrLength(script))); diff --git a/test/cctest/test-parsing.cc b/test/cctest/test-parsing.cc index 3101c19..8fbd60d 100644 --- a/test/cctest/test-parsing.cc +++ b/test/cctest/test-parsing.cc @@ -108,6 +108,7 @@ TEST(ScanKeywords) { TEST(ScanHTMLEndComments) { v8::V8::Initialize(); v8::Isolate* isolate = CcTest::isolate(); + v8::HandleScope handles(isolate); // Regression test. See: // http://code.google.com/p/chromium/issues/detail?id=53548 -- 2.7.4