From e9b995ecf4b1590023083580133a4c5e4ab72416 Mon Sep 17 00:00:00 2001 From: Yiwei Zhang Date: Tue, 13 Sep 2022 22:19:28 +0000 Subject: [PATCH] venus: ignore pInheritanceInfo if not secondary command buffer TEST: no segfault in dEQP-VK.api.command_buffers.bad_inheritance_info_random Fixes: 6f5289df533 ("venus: refactor VkCommandBufferBeginInfo fixups to function") Signed-off-by: Yiwei Zhang Part-of: --- src/virtio/vulkan/vn_command_buffer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/virtio/vulkan/vn_command_buffer.c b/src/virtio/vulkan/vn_command_buffer.c index 0276aff..bd9f136 100644 --- a/src/virtio/vulkan/vn_command_buffer.c +++ b/src/virtio/vulkan/vn_command_buffer.c @@ -656,6 +656,7 @@ vn_fix_command_buffer_begin_info(struct vn_command_buffer *cmd, const bool has_continue = begin_info->flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT; const bool has_renderpass = + is_cmd_secondary && begin_info->pInheritanceInfo->renderPass != VK_NULL_HANDLE; /* Can early-return if dynamic rendering is used and no structures need to -- 2.7.4